search

basnijholt / addon-otmonitor

OpenTherm Monitor Home Assistant supervisor add-on
17 stars 11 forks source link

Added otmonitor ports to addon config #3

Closed iamkarlson closed 4 years ago

basnijholt commented 4 years ago

That's great! Did you test it and it works?

iamkarlson commented 4 years ago

Yes, I've tested this from my repo, it works. Nonetheless, it's being very slow as an addon in general and I can't understand why, is it because of the settings for ports, or something else is breaking the stuff. Why I'm adding is that because the original addon doesn't seem to be working in my setup. I'm trying to investigate further.

basnijholt commented 4 years ago

Hmm, that is strange, for me, it's a very fast add-on...

What do you mean with "original add-on"? Do you mean this repo?

iamkarlson commented 4 years ago

yes, your repo

iamkarlson commented 4 years ago

Reverted back to your repo - addon is still very slow

basnijholt commented 4 years ago

So it the code of this PR still useful? Because it didn't solve your problem AFAIU.

iamkarlson commented 4 years ago

It depends on your setup. if you want to have access to otmonitor without home assistant - you need these settings. otherwise you don't. this is a kind of personal preferences, so please decide what would you want to have exposed in this addon