search

basnijholt / addon-otmonitor

OpenTherm Monitor Home Assistant supervisor add-on
17 stars 11 forks source link

After a container restart Alerts, Web Server lose their config #31

Closed mihsu81 closed 2 years ago

mihsu81 commented 3 years ago

Hi @basnijholt,

After a restart of the container the Alerts and Web Server tabs lose their config.

Also the settings added in the ThingSpeak tab are lost after navigating away from the tab.

Thank you in advance for your help in getting this solved. Mihai

fliphess commented 3 years ago

@mihsu81

I'm afraid you are correct: On container start some updates on the configuration are done using a startup script, but the config itself is very stateless and as such on container restart the manually configured settings are gone.

I'd love to make some edits to change this, but I'm currently a bit busy with other things.

I'll keep this issue open so if I can find some time to change this, I can have a look! :)

mihsu81 commented 3 years ago

Hi @fliphess, I've made some adjustments in a fork of your repo to include E-mail and ThingSpeak settings and added 3 more MQTT settings (All Messages, QOS and Retransmit). If you'd like I can do a PR. Thanks.

fliphess commented 3 years ago

Hey @mihsu81

I'd love to add it!

Feel free to create a PR so we can merge it in over here :)

fliphess commented 2 years ago

I've merged your PR, I think we can close this :)

If you think we should reopen it, please let me know :) Thanks a lot! 👍 🥇