search

basnijholt / addon-otmonitor

OpenTherm Monitor Home Assistant supervisor add-on
17 stars 11 forks source link

Connect over serial? #40

Closed Mrten closed 2 years ago

Mrten commented 2 years ago

My otgw is connected directly via serial, but it seems the config has a fixed type tcp. Would you consider adding an option to make that configurable?

fliphess commented 2 years ago

@Mrten If you can get it to work on a local fork: Sure! We'll merge it :) 👍

I'm not sure if/how it's possible to pass your serial to a container.... You could have a look how it's done in the zigbee2mqtt addon: They do some serial stuff so you might be able to use some of their config as an example.

Please make tcp the default so the addon doesn't break for current users and add some documentation so even lesser-technical users know how to configure it and keep me posted, I can always provide some input on how to proceed :)

I'm a bit busy lately so if I don't respond in time on your PR, please do some highlighting so I get some notifications here and there :) (I won't be able to test it myself as my otmonitor is at the other side of the house so please paste some log output in the PR so we have some basic idea it's working :)

Thanks!

fliphess commented 2 years ago

As this was merged in #44: Let's close this one :)