Closed Apteryks closed 5 months ago
Thanks for the report. Hmm, never seen that before (error "Calling ‘org-fold-core-region’ with missing SPEC")
@Apteryks Can you please test for me if some of the 3 tests don't fail anymore when you run make
on the master branch on your pc and report back? Thank you!
It appears to be resolved:
~/src/guix [env] git diff
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0fb3857847..dc66e61edd 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -36168,26 +36168,27 @@ (define-public emacs-org-journal
"-L" "."
"-l" "tests/org-journal-test"
"-f" "ert-run-tests-batch-and-exit")
- #:phases
- #~(modify-phases %standard-phases
- (add-before 'check 'disable-failing-tests
- (lambda _
- (let-syntax
- ((disable-tests
- (syntax-rules ()
- ((_ file ())
- (syntax-error "test names list must not be empty"))
- ((_ file (test-name ...))
- (substitute* file
- (((string-append "^\\(ert-deftest " test-name ".*") all)
- (string-append all "(skip-unless nil)\n")) ...)))))
- ;; These tests fail for unknown reasons (see:
- ;; https://github.com/bastibe/org-journal/issues/427).
- (disable-tests
- "tests/org-journal-test.el"
- ("org-journal-carryover-delete-empty-journal-test"
- "org-journal-carryover-items-test"
- "org-journal-scheduled-weekly-test"))))))))
+ ;; #:phases
+ ;; #~(modify-phases %standard-phases
+ ;; (add-before 'check 'disable-failing-tests
+ ;; (lambda _
+ ;; (let-syntax
+ ;; ((disable-tests
+ ;; (syntax-rules ()
+ ;; ((_ file ())
+ ;; (syntax-error "test names list must not be empty"))
+ ;; ((_ file (test-name ...))
+ ;; (substitute* file
+ ;; (((string-append "^\\(ert-deftest " test-name ".*") all)
+ ;; (string-append all "(skip-unless nil)\n")) ...)))))
+ ;; ;; These tests fail for unknown reasons (see:
+ ;; ;; https://github.com/bastibe/org-journal/issues/427).
+ ;; (disable-tests
+ ;; "tests/org-journal-test.el"
+ ;; ("org-journal-carryover-delete-empty-journal-test"
+ ;; "org-journal-carryover-items-test"
+ ;; "org-journal-scheduled-weekly-test"))))))
+ ))
(home-page "https://github.com/bastibe/org-journal")
(synopsis "Simple Org mode journaling mode")
(description
~/src/guix [env]$ ./pre-inst-env guix build emacs-org-journal --with-git-url=emacs-org-journal=https://github.com/bastibe/org-journal
updating checkout of 'https://github.com/bastibe/org-journal'...
retrieved commit 745ae15ff1a63d732f633ff282c19c206055f031
substitute: mise à jour des substituts depuis « https://ci.guix.gnu.org »... 100.0 %
substitute: mise à jour des substituts depuis « https://bordeaux.guix.gnu.org »... 100.0 %
The following derivation will be built:
/gnu/store/pc9kikh3qyixn1dc92ij2qsfqcx47kir-emacs-org-journal-2.2.0.drv
building /gnu/store/pc9kikh3qyixn1dc92ij2qsfqcx47kir-emacs-org-journal-2.2.0.drv...
starting phase `set-SOURCE-DATE-EPOCH'
phase `set-SOURCE-DATE-EPOCH' succeeded after 0.0 seconds
starting phase `set-paths'
environment variable `PATH' set to `/gnu/store/3ki76bxalfm5vpkk9jbddnw4gk420svv-emacs-minimal-29.1/bin:/gnu/store/sxx22f98vfbavcqmdksm6as8fvskpxiw-tar-1.34/bin:/gnu/store/x24bm49ag5dvki72mjdz195bfb89nrnb-gzip-1.12/bin:/gnu/store/j8wlfmlmfvpbza6is9wv9xsd8psrxn00-bzip2-1.0.8/bin:/gnu/store/gr0sy0m1mv36qv54idm6cn10l3mngshq-file-5.44/bin:/gnu/store/zmcf5kpqiighkbh7wslf91qdjwj06yr1-diffutils-3.8/bin:/gnu/store/210yfax18r2g2inxrml9435ikhfcca6m-patch-2.7.6/bin:/gnu/store/c8jyph2lxw0m9na34fg8h70n4nnnz7is-findutils-4.9.0/bin:/gnu/store/hc05d76f1j3iz3v2bs5jz4fpljl1r4dj-gawk-5.2.1/bin:/gnu/store/xxcfsimvxz7z4dj593gnqbkzc6picwzq-sed-4.8/bin:/gnu/store/yrv5f70mn83a876b78i5s79dd2hsh0zf-grep-3.8/bin:/gnu/store/6k1yys9wqrfn4y41ic1win8gpnimncwj-xz-5.2.8/bin:/gnu/store/a5i8avx826brw5grn3n4qv40g514505c-coreutils-9.1/bin:/gnu/store/wj7casda7rb55rvqjnpm0bm7a2zm6618-make-4.3/bin:/gnu/store/rib9g2ig1xf3kclyl076w28parmncg4k-bash-minimal-5.1.16/bin:/gnu/store/na1dpbbcxjaa3n8wkwrfpch476f90hlf-ld-wrapper-0/bin:/gnu/store/zh4x65snfis7svs6906gj1z8i7dx2j3m-binutils-2.38/bin:/gnu/store/5lqhcv91ijy82p92ac6g5xw48l0lwwz4-gcc-11.3.0/bin:/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35/bin:/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35/sbin'
environment variable `EMACSLOADPATH' set to `/gnu/store/3ki76bxalfm5vpkk9jbddnw4gk420svv-emacs-minimal-29.1/share/emacs/site-lisp'
environment variable `EMACSNATIVELOADPATH' unset
environment variable `INFOPATH' set to `/gnu/store/3ki76bxalfm5vpkk9jbddnw4gk420svv-emacs-minimal-29.1/share/info:/gnu/store/sxx22f98vfbavcqmdksm6as8fvskpxiw-tar-1.34/share/info:/gnu/store/x24bm49ag5dvki72mjdz195bfb89nrnb-gzip-1.12/share/info:/gnu/store/zmcf5kpqiighkbh7wslf91qdjwj06yr1-diffutils-3.8/share/info:/gnu/store/c8jyph2lxw0m9na34fg8h70n4nnnz7is-findutils-4.9.0/share/info:/gnu/store/hc05d76f1j3iz3v2bs5jz4fpljl1r4dj-gawk-5.2.1/share/info:/gnu/store/xxcfsimvxz7z4dj593gnqbkzc6picwzq-sed-4.8/share/info:/gnu/store/yrv5f70mn83a876b78i5s79dd2hsh0zf-grep-3.8/share/info:/gnu/store/a5i8avx826brw5grn3n4qv40g514505c-coreutils-9.1/share/info:/gnu/store/wj7casda7rb55rvqjnpm0bm7a2zm6618-make-4.3/share/info:/gnu/store/rib9g2ig1xf3kclyl076w28parmncg4k-bash-minimal-5.1.16/share/info:/gnu/store/zh4x65snfis7svs6906gj1z8i7dx2j3m-binutils-2.38/share/info:/gnu/store/5lqhcv91ijy82p92ac6g5xw48l0lwwz4-gcc-11.3.0/share/info:/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35/share/info'
environment variable `TREE_SITTER_GRAMMAR_PATH' unset
environment variable `BASH_LOADABLES_PATH' unset
environment variable `C_INCLUDE_PATH' set to `/gnu/store/3ki76bxalfm5vpkk9jbddnw4gk420svv-emacs-minimal-29.1/include:/gnu/store/j8wlfmlmfvpbza6is9wv9xsd8psrxn00-bzip2-1.0.8/include:/gnu/store/gr0sy0m1mv36qv54idm6cn10l3mngshq-file-5.44/include:/gnu/store/hc05d76f1j3iz3v2bs5jz4fpljl1r4dj-gawk-5.2.1/include:/gnu/store/6k1yys9wqrfn4y41ic1win8gpnimncwj-xz-5.2.8/include:/gnu/store/wj7casda7rb55rvqjnpm0bm7a2zm6618-make-4.3/include:/gnu/store/zh4x65snfis7svs6906gj1z8i7dx2j3m-binutils-2.38/include:/gnu/store/5lqhcv91ijy82p92ac6g5xw48l0lwwz4-gcc-11.3.0/include:/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35/include:/gnu/store/5iklcps70c0sfkxvlrhg8jhf3q4h18bj-linux-libre-headers-5.15.49/include'
environment variable `CPLUS_INCLUDE_PATH' set to `/gnu/store/3ki76bxalfm5vpkk9jbddnw4gk420svv-emacs-minimal-29.1/include:/gnu/store/j8wlfmlmfvpbza6is9wv9xsd8psrxn00-bzip2-1.0.8/include:/gnu/store/gr0sy0m1mv36qv54idm6cn10l3mngshq-file-5.44/include:/gnu/store/hc05d76f1j3iz3v2bs5jz4fpljl1r4dj-gawk-5.2.1/include:/gnu/store/6k1yys9wqrfn4y41ic1win8gpnimncwj-xz-5.2.8/include:/gnu/store/wj7casda7rb55rvqjnpm0bm7a2zm6618-make-4.3/include:/gnu/store/zh4x65snfis7svs6906gj1z8i7dx2j3m-binutils-2.38/include:/gnu/store/5lqhcv91ijy82p92ac6g5xw48l0lwwz4-gcc-11.3.0/include/c++:/gnu/store/5lqhcv91ijy82p92ac6g5xw48l0lwwz4-gcc-11.3.0/include:/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35/include:/gnu/store/5iklcps70c0sfkxvlrhg8jhf3q4h18bj-linux-libre-headers-5.15.49/include'
environment variable `LIBRARY_PATH' set to `/gnu/store/3ki76bxalfm5vpkk9jbddnw4gk420svv-emacs-minimal-29.1/lib:/gnu/store/j8wlfmlmfvpbza6is9wv9xsd8psrxn00-bzip2-1.0.8/lib:/gnu/store/gr0sy0m1mv36qv54idm6cn10l3mngshq-file-5.44/lib:/gnu/store/hc05d76f1j3iz3v2bs5jz4fpljl1r4dj-gawk-5.2.1/lib:/gnu/store/6k1yys9wqrfn4y41ic1win8gpnimncwj-xz-5.2.8/lib:/gnu/store/zh4x65snfis7svs6906gj1z8i7dx2j3m-binutils-2.38/lib:/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35/lib:/gnu/store/l0yryi5jsa1grnvw01c9nkz9c81cv224-glibc-2.35-static/lib:/gnu/store/visfdda934gvivwihwhlm63fdqhhcc8a-glibc-utf8-locales-2.35/lib'
environment variable `GUIX_LOCPATH' set to `/gnu/store/visfdda934gvivwihwhlm63fdqhhcc8a-glibc-utf8-locales-2.35/lib/locale'
phase `set-paths' succeeded after 0.0 seconds
starting phase `install-locale'
using 'en_US.utf8' locale for category "LC_ALL"
phase `install-locale' succeeded after 0.0 seconds
starting phase `unpack'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/.gitignore' -> `./.gitignore'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/CHANGELOG' -> `./CHANGELOG'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/CONTRIBUTORS' -> `./CONTRIBUTORS'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/LICENSE' -> `./LICENSE'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/MAINTAINERS' -> `./MAINTAINERS'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/Makefile' -> `./Makefile'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/README.org' -> `./README.org'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/org-journal.el' -> `./org-journal.el'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/org-journal.svg' -> `./org-journal.svg'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/tests/org-journal-test.el' -> `./tests/org-journal-test.el'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/tests/journals/yearly/carryover1/20190101' -> `./tests/journals/yearly/carryover1/20190101'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/tests/journals/yearly/carryover1/20200101' -> `./tests/journals/yearly/carryover1/20200101'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/tests/journals/daily/carryover1/2020-10-21.org' -> `./tests/journals/daily/carryover1/2020-10-21.org'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/tests/journals/daily/carryover1/2020-10-22.org' -> `./tests/journals/daily/carryover1/2020-10-22.org'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/.github/workflows/test.yml' -> `./.github/workflows/test.yml'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/.github/ISSUE_TEMPLATE/bug_report.md' -> `./.github/ISSUE_TEMPLATE/bug_report.md'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/.github/ISSUE_TEMPLATE/feature_request.md' -> `./.github/ISSUE_TEMPLATE/feature_request.md'
phase `unpack' succeeded after 0.0 seconds
starting phase `expand-load-path'
source directory "/tmp/guix-build-emacs-org-journal-2.2.0.drv-0/source" prepended to the `EMACSLOADPATH' environment variable
phase `expand-load-path' succeeded after 0.0 seconds
starting phase `add-install-to-native-load-path'
phase `add-install-to-native-load-path' succeeded after 0.0 seconds
starting phase `patch-usr-bin-file'
phase `patch-usr-bin-file' succeeded after 0.0 seconds
starting phase `patch-source-shebangs'
phase `patch-source-shebangs' succeeded after 0.0 seconds
starting phase `patch-generated-file-shebangs'
phase `patch-generated-file-shebangs' succeeded after 0.0 seconds
starting phase `check'
Running 10 tests (2024-02-19 03:46:48+0000, selector ‘t’)
passed 1/10 org-journal-calendar-date-from-file-test (0.001452 sec)
passed 2/10 org-journal-carryover-delete-empty-journal-test (0.859395 sec)
passed 3/10 org-journal-carryover-items-test (0.153362 sec)
passed 4/10 org-journal-carryover-keep-parents-test (0.048188 sec)
passed 5/10 org-journal-convert-time-to-file-type-time-test (0.000921 sec)
passed 6/10 org-journal-insert-header-test (0.018902 sec)
passed 7/10 org-journal-scheduled-carryover-daily-test (0.035104 sec)
passed 8/10 org-journal-scheduled-carryover-yearly-test (0.042284 sec)
passed 9/10 org-journal-scheduled-weekly-test (0.029215 sec)
passed 10/10 org-journal-search-build-file-list-test (0.135819 sec)
Ran 10 tests, 10 results as expected, 0 unexpected (2024-02-19 03:46:49+0000, 1.325841 sec)
phase `check' succeeded after 2.1 seconds
starting phase `install'
`/tmp/guix-build-emacs-org-journal-2.2.0.drv-0/source/org-journal.el' -> `/gnu/store/4z2l7k8qhwis9lsiyliy76v2kja73903-emacs-org-journal-2.2.0/share/emacs/site-lisp/org-journal-2.2.0/org-journal.el'
phase `install' succeeded after 0.0 seconds
starting phase `make-autoloads'
INFO Scraping files for loaddefs...
INFO Scraping files for loaddefs...done
GEN org-journal-autoloads.el
phase `make-autoloads' succeeded after 0.1 seconds
starting phase `enable-autoloads-compilation'
phase `enable-autoloads-compilation' succeeded after 0.0 seconds
starting phase `patch-el-files'
phase `patch-el-files' succeeded after 0.0 seconds
starting phase `ensure-package-description'
org-journal-pkg.el file generated.
phase `ensure-package-description' succeeded after 0.2 seconds
starting phase `build'
In org-journal--insert-entry-header:
org-journal.el:751:37: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.
In org-journal-carryover-items:
org-journal.el:952:33: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.
org-journal.el:953:74: Warning: ‘point-at-eol’ is an obsolete function (as of 29.1); use ‘line-end-position’ or ‘pos-eol’ instead.
In org-journal--carryover-item-with-parents:
org-journal.el:1035:18: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.
In org-journal-reschedule-scheduled-entry:
org-journal.el:1199:68: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.
In org-journal--deserialize:
org-journal.el:1341:61: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.
org-journal.el:1341:76: Warning: ‘point-at-eol’ is an obsolete function (as of 29.1); use ‘line-end-position’ or ‘pos-eol’ instead.
phase `build' succeeded after 0.6 seconds
starting phase `validate-compiled-autoloads'
Loading /gnu/store/4z2l7k8qhwis9lsiyliy76v2kja73903-emacs-org-journal-2.2.0/share/emacs/site-lisp/org-journal-2.2.0/org-journal-autoloads.elc...
phase `validate-compiled-autoloads' succeeded after 0.0 seconds
starting phase `move-doc'
phase `move-doc' succeeded after 0.0 seconds
starting phase `patch-shebangs'
phase `patch-shebangs' succeeded after 0.0 seconds
starting phase `strip'
phase `strip' succeeded after 0.0 seconds
starting phase `validate-runpath'
phase `validate-runpath' succeeded after 0.0 seconds
starting phase `validate-documentation-location'
phase `validate-documentation-location' succeeded after 0.0 seconds
starting phase `delete-info-dir-file'
phase `delete-info-dir-file' succeeded after 0.0 seconds
starting phase `patch-dot-desktop-files'
phase `patch-dot-desktop-files' succeeded after 0.0 seconds
starting phase `make-dynamic-linker-cache'
phase `make-dynamic-linker-cache' succeeded after 0.0 seconds
starting phase `install-license-files'
installing 1 license files from '.'
phase `install-license-files' succeeded after 0.0 seconds
starting phase `reset-gzip-timestamps'
phase `reset-gzip-timestamps' succeeded after 0.0 seconds
starting phase `compress-documentation'
phase `compress-documentation' succeeded after 0.0 seconds
successfully built /gnu/store/pc9kikh3qyixn1dc92ij2qsfqcx47kir-emacs-org-journal-2.2.0.drv
/gnu/store/4z2l7k8qhwis9lsiyliy76v2kja73903-emacs-org-journal-2.2.0
Awesome, thank you!
Describe the bug The test suite fails as shown below.
To Reproduce run
guix build emacs-org-journal
; you should see in the build log:Expected behavior The test suite should pass.
Desktop (please complete the following information):