Object API - Githubissues

bat-tomr / dialog-node

x-platform simple GUI dialogs for node js. Inspired by dialog from Tomás Pollak

MIT License

13 stars 11 forks source link

Object API #8

Open brettz9 opened 5 years ago

brettz9 commented 5 years ago

If you really need older Node support, I can add Babel...

Are you still maintaining, @bat-tomr ?

ccc-tomr commented 5 years ago

Hi Brett,

yes I am still maintaining it, I am just on an international trip. I like your changes and plan to test and pull them in next week.

Thanks,

Thomas

On May 23, 2019, at 16:38, Brett Zamir <notifications@github.com mailto:notifications@github.com> wrote:

If you really need older Node support, I can add Babel...

Are you still maintaining, @bat-tomr https://github.com/bat-tomr ?

You can view, comment on, or merge this pull request online at:

https://github.com/bat-tomr/dialog-node/pull/8 https://github.com/bat-tomr/dialog-node/pull/8 Commit Summary

Fix: Avoid global cb Add and use automator workflow for date picker
Breaking change: Use minimum supported Node version (8.0.0), allowing us to use let, destructuring, etc. without Babel File Changes

A .eslintignore https://github.com/bat-tomr/dialog-node/pull/8/files#diff-0 (1) A .eslintrc.js https://github.com/bat-tomr/dialog-node/pull/8/files#diff-1 (23) A .gitignore https://github.com/bat-tomr/dialog-node/pull/8/files#diff-2 (1) M README.md https://github.com/bat-tomr/dialog-node/pull/8/files#diff-3 (54) M datepicker.osa https://github.com/bat-tomr/dialog-node/pull/8/files#diff-4 (144) A datepicker.workflow/Contents/Info.plist https://github.com/bat-tomr/dialog-node/pull/8/files#diff-5 (8) A datepicker.workflow/Contents/QuickLook/Thumbnail.png https://github.com/bat-tomr/dialog-node/pull/8/files#diff-6 (0) A datepicker.workflow/Contents/document.wflow https://github.com/bat-tomr/dialog-node/pull/8/files#diff-7 (126) A datepicker2.app/Contents/Info.plist https://github.com/bat-tomr/dialog-node/pull/8/files#diff-8 (109) A datepicker2.app/Contents/MacOS/Application Stub https://github.com/bat-tomr/dialog-node/pull/8/files#diff-9 (0) A datepicker2.app/Contents/Resources/AutomatorApplet.icns https://github.com/bat-tomr/dialog-node/pull/8/files#diff-10 (0) A datepicker2.app/Contents/Resources/ar.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-11 (0) A datepicker2.app/Contents/Resources/ca.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-12 (0) A datepicker2.app/Contents/Resources/cs.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-13 (0) A datepicker2.app/Contents/Resources/da.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-14 (0) A datepicker2.app/Contents/Resources/de.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-15 (0) A datepicker2.app/Contents/Resources/el.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-16 (0) A datepicker2.app/Contents/Resources/en.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-17 (0) A datepicker2.app/Contents/Resources/en_AU.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-18 (0) A datepicker2.app/Contents/Resources/en_GB.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-19 (0) A datepicker2.app/Contents/Resources/es.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-20 (0) A datepicker2.app/Contents/Resources/es_419.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-21 (0) A datepicker2.app/Contents/Resources/fi.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-22 (0) A datepicker2.app/Contents/Resources/fr.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-23 (0) A datepicker2.app/Contents/Resources/fr_CA.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-24 (0) A datepicker2.app/Contents/Resources/he.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-25 (0) A datepicker2.app/Contents/Resources/hi.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-26 (0) A datepicker2.app/Contents/Resources/hr.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-27 (0) A datepicker2.app/Contents/Resources/hu.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-28 (0) A datepicker2.app/Contents/Resources/id.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-29 (0) A datepicker2.app/Contents/Resources/it.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-30 (0) A datepicker2.app/Contents/Resources/ja.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-31 (0) A datepicker2.app/Contents/Resources/ko.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-32 (0) A datepicker2.app/Contents/Resources/ms.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-33 (0) A datepicker2.app/Contents/Resources/nl.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-34 (0) A datepicker2.app/Contents/Resources/no.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-35 (0) A datepicker2.app/Contents/Resources/pl.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-36 (0) A datepicker2.app/Contents/Resources/pt.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-37 (0) A datepicker2.app/Contents/Resources/pt_PT.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-38 (0) A datepicker2.app/Contents/Resources/ro.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-39 (0) A datepicker2.app/Contents/Resources/ru.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-40 (0) A datepicker2.app/Contents/Resources/sk.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-41 (0) A datepicker2.app/Contents/Resources/sv.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-42 (0) A datepicker2.app/Contents/Resources/th.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-43 (0) A datepicker2.app/Contents/Resources/tr.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-44 (0) A datepicker2.app/Contents/Resources/uk.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-45 (0) A datepicker2.app/Contents/Resources/vi.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-46 (0) A datepicker2.app/Contents/Resources/zh_CN.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-47 (0) A datepicker2.app/Contents/Resources/zh_HK.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-48 (0) A datepicker2.app/Contents/Resources/zh_TW.lproj/InfoPlist.strings https://github.com/bat-tomr/dialog-node/pull/8/files#diff-49 (0) A datepicker2.app/Contents/document.wflow https://github.com/bat-tomr/dialog-node/pull/8/files#diff-50 (310) M example.js https://github.com/bat-tomr/dialog-node/pull/8/files#diff-51 (17) M index.js https://github.com/bat-tomr/dialog-node/pull/8/files#diff-52 (368) A package-lock.json https://github.com/bat-tomr/dialog-node/pull/8/files#diff-53 (959) M package.json https://github.com/bat-tomr/dialog-node/pull/8/files#diff-54 (14) M test-dialog-node.js https://github.com/bat-tomr/dialog-node/pull/8/files#diff-55 (33) Patch Links:

https://github.com/bat-tomr/dialog-node/pull/8.patch https://github.com/bat-tomr/dialog-node/pull/8.patch https://github.com/bat-tomr/dialog-node/pull/8.diff https://github.com/bat-tomr/dialog-node/pull/8.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bat-tomr/dialog-node/pull/8?email_source=notifications&email_token=ABUVOS4B2EJJWTKDOXFYP3LPW2T77A5CNFSM4HPGLQZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GVPMUWA, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUVOS7D4IHUC4NFLF6QZK3PW2T77ANCNFSM4HPGLQZQ.

brettz9 commented 5 years ago

Great, thanks... I added another commit refactoring a little bit further...

I'd also find it ideal to add some ESLint rules to force lines such as this:

question ( message, title, timeout, callback){

...to either consistently enforce a space at the beginning and not at the end, or use what seems to be the much more common convention of the following (including the space between the bracket):

question (message, title, timeout, callback) {

I'd also like to enforce consistent brace style. I can enforce https://eslint.org/docs/rules/brace-style#stroustrup style if you wish, though https://eslint.org/docs/rules/brace-style#1tbs is the default and seems most common.

I could also add an ESLint config to catch more errors or styling inconsistencies than eslint:recommended does, e.g., "standard", "airbnb", or my own "ash-nazg", though if so, it'd be nice to know your styling preferences for the above, so I know whether to enforce their styling rules or use the config but override with your styling preference for the above.

ccc-tomr commented 5 years ago

Hi Brettz9, on which OSs did you test your changes ? Let me know what couldn't test and I will test it before pulling the request into master

brettz9 commented 5 years ago

I only tested on Mac OS X (Mojave).