Add compatibility with base-4.8

[hvr]

Without this, the following compile failure occurs

  Text/PrettyPrint/ANSI/Leijen.hs:312:24:
      Ambiguous occurrence ‘<$>’
      It could refer to either ‘Text.PrettyPrint.ANSI.Leijen.<$>’,
                   defined at Text/PrettyPrint/ANSI/Leijen.hs:372:3
                or ‘Prelude.<$>’,
                   imported from ‘Prelude’ at Text/PrettyPrint/ANSI/Leijen.hs:76:8-35
                   (and originally defined in ‘Data.Functor’)

as <$> is re-exported from Prelude starting with base-4.8

[23Skidoo]

@batterseapower has been AWOL for some time. I think we should just fork this package.

[hvr]

@23Skidoo afaik, @ekmett is trying to reach out to @batterseapower to ask to take over ansi-wl-pprint

[23Skidoo]

@hvr IIRC he couldn't be reached when test-framework was forked.

[gbaz]

no he could be reached, it just took a bit. it was forked anyway.

[cartazio]

I dont think we need fork it. Nor should we without further discussion from batterseapower

This patch looks pretty reasonable. Would this be a patch level release?

[hvr]

@cartazio yes, it would be a patch-level rls (i.e. 0.6.7.2) ... but to add to the confusion, Hackage seems to carry a newer version (0.6.7.1) than is available in this repository (0.6.7)... :-(

PS: actually, 0.6.7.1 is available in this repo, but only accessible via the v0.6.7.1 tag, but not via any branch.

[cartazio]

Ewww. So we need to diff Hackage vs master before so we can make sure were not reintroducing bugs. On Mar 17, 2015 9:15 AM, "Herbert Valerio Riedel" notifications@github.com wrote:

@cartazio https://github.com/cartazio yes, it would... but to add to the confusion, Hackage seems to have a newer version (0.6.7.1) than is available in this repository (0.6.7)... :-(

— Reply to this email directly or view it on GitHub https://github.com/batterseapower/ansi-wl-pprint/pull/11#issuecomment-82340090 .

[ddssff]

I checked, its just the version number.

[hvr]

@ddssff if I look at http://hdiff.luite.com/cgit/ansi-wl-pprint/commit?id=0.6.7.1 the delta is a bit more

in any case, I'll rebase this PR on top of 96cb3469a87b60d6465c160fb24375bcbdf59507 RSN

update: nevermind, you're were right... this is just too confusing ;-)

[ddssff]

It would be great to get these changes into hackage.

[hvr]

As over 2w have passed w/o any lifesign from @batterseapower I've gone ahead and uploaded http://hackage.haskell.org/package/ansi-wl-pprint-0.6.7.2

I'll leave this PR open so it can be merged at some point in the future

[23Skidoo]

So this PR is still unmerged, and I have another small fix incoming. Can we now fork the package? I'm willing to maintain.

[gbaz]

:+1:

We should follow the takeover process of course, but given history we can err on the short waiting period side.

[hvr]

@23Skidoo Fyi, @ekmett is already registered as http://hackage.haskell.org/package/ansi-wl-pprint/maintainers/ and he's already forked the repo over at https://github.com/ekmett/ansi-wl-pprint

So all is already in place, @ekmett just needs to act on it :-)

PS: I've just filed https://github.com/ekmett/ansi-wl-pprint/pull/1

[ekmett]

Merged there.

[ekmett]

@gbaz I already went through the process back in March.

[hvr]

With http://hackage.haskell.org/package/ansi-wl-pprint-0.6.7.3 I consider this PR completed

[23Skidoo]

Nice. Thanks, @ekmett!