battleblow / openjdk-jdk11u

BSD port of OpenJDK 11
GNU General Public License v2.0
9 stars 8 forks source link

Rename the macros to extract a single arm64 ID field. #93

Closed MikaelUrankar closed 5 years ago

MikaelUrankar commented 5 years ago

It fixes the build on FreeBSD 13-current after https://github.com/freebsd/freebsd/commit/d4cdc59b4194a31f316ce9dc5d67bd8e0b4c77f3 and https://github.com/freebsd/freebsd/commit/a8fc8da0637d43f8b27cd615f5c3270219f6c083 tested on FreeBSD 12.1 and 13 (1300057)

battleblow commented 5 years ago

This looks good to me, but I'd like to wait for Kurt's review with regards to whether this will cause any problems for OpenBSD

Mikael, as an aside, do you happen to have an OCA on file with Oracle at all? If not, would you be willing to do so? I'm just trying to get a handle on our current situation in terms of whether we can satisfy legal requirements if we get to a point where we start upstreaming these changes.

MikaelUrankar commented 5 years ago

Mikael, as an aside, do you happen to have an OCA on file with Oracle at all? If not, would you be willing to do so? I'm just trying to get a handle on our current situation in terms of whether we can satisfy legal requirements if we get to a point where we start upstreaming these changes.

I think I signed it 4 years ago when I ported openjdk7 on armv6 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201308#c1) but I can't find any trace of it.

ok found it: https://www.oracle.com/technetwork/community/oca-486395.html#u

battleblow commented 5 years ago

Mikael, as an aside, do you happen to have an OCA on file with Oracle at all? If not, would you be willing to do so? I'm just trying to get a handle on our current situation in terms of whether we can satisfy legal requirements if we get to a point where we start upstreaming these changes.

I think I signed it 4 years ago when I ported openjdk7 on armv6 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201308#c1) but I can't find any trace of it.

ok found it: https://www.oracle.com/technetwork/community/oca-486395.html#u

Great! Thank you for checking