tag selector for newEntry form - Githubissues

baudren / NoteOrganiser

Scientific Note Taking

MIT License

13 stars 6 forks source link

tag selector for newEntry form #63

Closed egolus closed 9 years ago

egolus commented 9 years ago

(this is far from ready to merge)

see: #42

baudren commented 9 years ago

Nice first draft. A few comments:

it would be nice to be able to click on the whole line to check the tag, instead of just on the checkbox (right now, it enters editing the tag name...).
we have to think about both keyboard and mouse support, when the filter will be implemented, that is, if we start typing a tag, and there is only one possibility, typing Enter should add the tag, not try to validate the whole form.
As discussed in gitter - could be nice to have the selected tags displayed as mail recipients (like standard gmail interface, e.g.)

baudren commented 9 years ago

Still to do:

[x] ~~convert the ; to , once finished editing (or during?)~~
[x] ~~would it be possible that the first entry gets highlighted, to understand that if we press enter, this will hapen?~~ Won't fix for now
[x] ~~initial focus should be on the title line, not the tags~~
[x] ~~display the drop down on click (show a small arrow, like a standard combo box, for mouse oriented people)~~

landscape-bot commented 9 years ago

Repository health decreased by 0.84% when pulling 4574775 on 42-TagSelector into ca2308c on devel.

11 new problems were found (including 1 error and 0 code smells).
1 problem was fixed (including 0 errors and 0 code smells).

landscape-bot commented 9 years ago

Repository health decreased by 0.63% when pulling a30ecf2 on 42-TagSelector into ca2308c on devel.

11 new problems were found (including 1 error and 0 code smells).
1 problem was fixed (including 0 errors and 0 code smells).

landscape-bot commented 9 years ago

Repository health decreased by 0.63% when pulling dac6e41 on 42-TagSelector into ca2308c on devel.

11 new problems were found (including 1 error and 0 code smells).
1 problem was fixed (including 0 errors and 0 code smells).

egolus commented 9 years ago

I rebased this, so make sure to get the right state!

landscape-bot commented 9 years ago

Repository health decreased by 0.64% when pulling e0c1856 on 42-TagSelector into d862c45 on devel.

22 new problems were found (including 2 errors and 0 code smells).
13 problems were fixed (including 1 error and 0 code smells).

landscape-bot commented 9 years ago

Repository health increased by 0.89% when pulling a63b8e4 on 42-TagSelector into d862c45 on devel.

19 new problems were found (including 0 errors and 0 code smells).
15 problems were fixed (including 3 errors and 0 code smells).

landscape-bot commented 9 years ago

Repository health increased by 0.81% when pulling 37416a3 on 42-TagSelector into 966105e on devel.

21 new problems were found (including 0 errors and 0 code smells).
15 problems were fixed (including 3 errors and 0 code smells).

baudren commented 9 years ago

It can be merged.