search

bazel-contrib / rules-template

A template for creating a new Bazel ruleset
Apache License 2.0
78 stars 20 forks source link

chore: enable buildifier #65

Closed alexeagle closed 1 year ago

alexeagle commented 1 year ago

This checks that contributors have formatted their Bazel files.

Also ran the pre-commit over the whole repo to apply those formatting suggestions as well.

gregmagolan commented 1 year ago

We should also bump the Bazel version here. Its still at 6.0.0rc4

fmeum commented 1 year ago

buildifier_prebuilt needs to be added to WORKSPACE as well since it's loaded from in the top-level BUILD file.

alexeagle commented 1 year ago

Let's not have it in the root BUILD file then :) No need for pre-bzlmod involved in this.

alexeagle commented 1 year ago

Even better we can remove the workspace setup from the root module

alexeagle commented 1 year ago

Thanks @keith for the nice buildifier setup!