bazelbuild / rules_k8s

This repository contains rules for interacting with Kubernetes configurations / clusters.
Apache License 2.0
290 stars 137 forks source link

Enable wrapping k8s_objects diff exit codes #680

Closed irlevesque closed 2 years ago

irlevesque commented 2 years ago

Fixes: https://github.com/bazelbuild/rules_k8s/issues/679

This diff proposes one strategy we could take to wrapping the command execution of the kubectl diffs in order to address the above issue.

k8s-ci-robot commented 2 years ago

Hi @irlevesque. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chases2 commented 2 years ago

/ok-to-test

This looks like an acceptable option to me. Please be sure to:

irlevesque commented 2 years ago

@chases2 all set, thanks!

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chases2, irlevesque

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/bazelbuild/rules_k8s/blob/master/OWNERS)~~ [chases2] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment