bbangert / velruse

Simplifying third-party authentication for web applications.
http://packages.python.org/velruse/index.html
MIT License
252 stars 86 forks source link

Change the default value of the facebook provider "scope" parameter from None to empty string #93

Closed andornaut closed 12 years ago

andornaut commented 12 years ago

The Facebook Provider "scope" configuration should default to empty string instead of None (which ends up being converted to the string 'None').

Previously, omitting  "facebook.scope" from the .ini file would result in an error upon login attempt: "Invalid parameter Scope' ... "'None' is not a valid value..."

andornaut commented 12 years ago

I noticed a similar issue with other configuration options for other providers, so perhaps a better approach would be to convert all "false-y" values to empty string at a lower level in the process?