Helm-resume does not resume helm-projectile-ag search correctly

bbatsov / helm-projectile

Helm UI for Projectile

329 stars 71 forks source link

Helm-resume does not resume helm-projectile-ag search correctly #1

Closed greenrd closed 7 years ago

greenrd commented 8 years ago

helm-projectile-ag works fine for me, but when I use helm-resume to resume a previous search, I experience a couple of issues. Firstly, navigating to a file does not always work - sometimes the filename is incorrectly constructed based on the current directory of the buffer I was in instead of the root directory of the projectile project. Secondly, editing the search causes no results to be displayed (I suspect the same fundamental cause - searching in the subdirectory instead of the projectile root directory).

xiongtx commented 7 years ago

I cannot reproduce this.

If you're still encountering this after updating to the latest version of helm-projectile, please provide a minimal project (Git repo) and more details via the issue template, then re-open this issue.

jlisee commented 6 years ago

(A good workaround for this would be instructions on how to keep the search open while I look through results)

To try and provide some more details here is what I am seeing:

Open a file not in the root of the repository
Ctrl-C P S R (search with ripgrep)
Type a search that returns multiple results in different directories than your current one
Notice the results all appear as relative paths (like ../../../foo.json)
Hint enter to select a result (helm-rg buffer now gone)
Run M-x helm-resume
In the restored buffer select a different result and get an empty buffer instead of the file

xiongtx commented 6 years ago

@jlisee For that particular issue, see cosmicexplorer/helm-rg#11.