search

bbbbcccd / pe

0 stars 0 forks source link

S/O not allowed in name of candidate #4

Open bbbbcccd opened 2 weeks ago

bbbbcccd commented 2 weeks ago

When adding a name with S/O, HiredFiredPro considers this as a invalid name. This is not representative of the real world where names can include S/O

Steps to reproduce:

  1. Clear the contact list
  2. Type command add n/Kushal s/o Zac j/Software Engineer p/98765432 e/johnd@example.com s/Python i/7.5 t/friends t/owesMoney

Actual:

Screenshot 2024-11-15 at 4.41.00 PM.png

Expected: The candidate should be added to the list.

Justification: Since hiring managers need the full name of candidates, it is inconvenient for them to use an app that does not allow addition of names with S/O

soc-pe-bot commented 1 week ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Invalid error message when using "d/o" in name

Input: edit 3 n/Maria d/o Hughman Patrick

I expected this command to be accepted as "d/o" is a valid name and is highly likely to be come across since this app is for managing job candidates. However, I am met with the following error message that it is an invalid name.

It would be good to allow for "d/o" to be accepted as it is relatively common for people to shorten "Daughter of" to "d/o" and this shortened version even be in their legal name as well.

image.png

[original: nus-cs2103-AY2425S1/pe-interim#334] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

As mentioned below, the UG clearly specifies that the name can only be alphanumeric and hence words like 's/o' are not in scope of the UG. Furthermore, the user receives a suitable error message when attempting to add a symbol to their name which would lead to them working around the issue e.g. by fully spelling out "son of".

Therefore, we will be assigning this as "Not_In_Scope"

image.png

Constraints of name stated below:

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]