bbc / VideoContext

An experimental HTML5 & WebGL video composition and rendering API.
http://bbc.github.io/VideoContext/
Apache License 2.0
1.33k stars 157 forks source link

Hotfix issue 67 #70

Closed PTaylour closed 6 years ago

PTaylour commented 6 years ago

Roll back change that removed video video readState check

see https://github.com/bbc/VideoContext/issues/67

Rolling back this commit https://github.com/bbc/VideoContext/commit/617528f78de2006084803a4fa54d6672f70b4095 that prevents updates to currentTime being reflected in render when ctx is paused.

Problem reproduced in firefox 58.0 and Chromium 58.0. Doesn't look to effect chrome 68.

Fix tested in firefox 58.0, Chromium 58.0 and Chrome 68.

Unit test added for update function of sourceNode (However, actual problem not reproduced in node environment with mocked webgl instance)