search

bbc / VideoContext

An experimental HTML5 & WebGL video composition and rendering API.
http://bbc.github.io/VideoContext/
Apache License 2.0
1.33k stars 157 forks source link

Fix videonode crash #72

Closed PTaylour closed 6 years ago

PTaylour commented 6 years ago

See https://github.com/bbc/VideoContext/issues/71

There are a couple of places where a fix could be implemented. I'm going to check which approach is best before merging

PTaylour commented 6 years ago

It looks safer conceptually to change the condition that dictates when the node should load.

changing the condition that triggers play would mean that the play state is only updated on the tick after startTime, which doesn't seem right.

PTaylour commented 6 years ago

[I'm going to only build the docs etc on merge]

PTaylour commented 6 years ago

@samdnic yeah regret on the whitespace and the build commit. I'll add a formatter at some point to try and get it more consistent