always read volume from mediaNode._attributes.volume

bbc / VideoContext

An experimental HTML5 & WebGL video composition and rendering API.

http://bbc.github.io/VideoContext/

Apache License 2.0

1.33k stars 157 forks source link

Closed PTaylour closed 6 years ago

PTaylour commented 6 years ago

Until now volume existed as two bits of state. This commit favours the attributes object as the single source of truth.

This is a good opportunity to write some integration tests

[x] test that on supplying no attributes it doesn't break (a default volume is set)
[x] test that on setting the volume via the setter, this is still the case after a load

Sacharified commented 6 years ago

Great stuff! Standardising the way these properties are set is super important.