search

bbc / simorgh

The BBC's Open Source Web Application. Contributions welcome! Used on some of our biggest websites, e.g.
https://www.bbc.com/thai
Other
1.39k stars 220 forks source link

Includes RequireJS stubbing for VJ/IDT1 #5750

Closed simonsinclair closed 4 years ago

simonsinclair commented 4 years ago

Is your feature request related to a problem? Please describe.

We've identified that some includes depend on Require JS and probably don't include it. We need to ensure that Require JS is in the page before rendering Includes of this type.

Note that while all IDT1 content needs RequireJS, only some VJ content does.

Describe the solution you'd "like"

Describe alternatives you've considered

n/a

Testing notes

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

Additional context Add any other context or screenshots about the feature request here.

andrewscfc commented 4 years ago

Blocked until we can take forward one of our POCs for integrating includes into the page: https://github.com/bbc/simorgh/issues/5822 https://github.com/bbc/simorgh/issues/5823 https://github.com/bbc/simorgh/issues/5824

jamesdonoh commented 4 years ago

Should no longer be blocked.

andrewscfc commented 4 years ago

@paruchurisilpa , please use this temporary branch to test this issue with IDT1 and VJ includes: https://github.com/bbc/simorgh/pull/6405

paruchurisilpa commented 4 years ago

Includes available on test:

IDT

Story with IDT2 includes

paruchurisilpa commented 4 years ago

Checked the includes mentioned above and the includes are rendered OK. Thanks Rowland for helping with some of the includes testing.LGTM..