bbcarchdev / spindle

RES Linked Open Data aggregation engine
https://bbcarchdev.github.io/spindle/
Apache License 2.0
2 stars 1 forks source link

Spindle-strip does not remove triples #97

Closed cgueret closed 7 years ago

cgueret commented 7 years ago

The triples are logged as being removed but are still found in the proxy descriptions in Quilt

nevali commented 7 years ago

Can you provide an example triple, including the engine workflow you've configured?

cgueret commented 7 years ago

Here is the test file https://github.com/bbcarchdev/acropolis/blob/1e5f17496c8b5f9df5d2317598b98b1122c95de3/test/data/ou-podcast.nq and the workflow config https://github.com/bbcarchdev/acropolis/blob/1e5f17496c8b5f9df5d2317598b98b1122c95de3/docker/twine.conf

We do "workflow=spindle-strip,sparql-get,spindle-correlate,sparql-put"

cgueret commented 7 years ago

From the logs:

twine-remote_1   | twinecli: [Debug] invoking graph processor 'spindle-strip' for <http://data.open.ac.uk/resource/podcast/1002ac938fc6f7a91f645db2ce12ef52>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://digitalbazaar.com/media/duration>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://www.w3.org/TR/2010/WD-mediaont-10-20100608/description>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://data.open.ac.uk/podcast/ontology/embedCode>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://data.open.ac.uk/podcast/ontology/embedCode>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://www.w3.org/TR/2010/WD-mediaont-10-20100608/format>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://www.w3.org/TR/2010/WD-mediaont-10-20100608/locator>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://dbpedia.org/property/url>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://www.w3.org/TR/2010/WD-mediaont-10-20100608/publisher>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://www.w3.org/TR/2010/WD-mediaont-10-20100608/language>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://purl.org/media#depiction>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://purl.org/dc/terms/published>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://www.w3.org/TR/2010/WD-mediaont-10-20100608/copyright>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://purl.org/media#duration>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://digitalbazaar.com/media/depiction>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://www.w3.org/TR/2010/WD-mediaont-10-20100608/createDate>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://www.w3.org/TR/2010/WD-mediaont-10-20100608/duration>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://digitalbazaar.com/media/download>
twine-remote_1   | twinecli: [Debug] spindle-strip: removing triple with predicate <http://www.w3.org/TR/2010/WD-mediaont-10-20100608/title>

but those triples are still served: screen shot 2016-11-21 at 11 47 04

cgueret commented 7 years ago

See https://github.com/bbcarchdev/spindle/pull/100 for a proposed fix & enhancement

cgueret commented 7 years ago

Fixed with https://github.com/bbcarchdev/spindle/commit/2734be2d252014eacaa24c8706467599398dadd6