search

bbepis / XUnity.AutoTranslator

MIT License
2.02k stars 293 forks source link

Translation scoping - if GetScopeFromComponent fails, use GetActiveSceneId instead of -1 #619

Closed Lmeks closed 2 weeks ago

Lmeks commented 2 weeks ago

https://github.com/bbepis/XUnity.AutoTranslator/issues/617

ManlyMarco commented 2 weeks ago

Did you test the build? I can build it for you for testing if needed.

Lmeks commented 2 weeks ago

Do you mean the debug build? 2024-11-15_07-43-26 Well, I checked that ignoring -1 return fixes #set level scoping in my case (BepInEx-IL2CPP 5.3.1, I couldnt change the font on 5.4), so yeah it works perfectly on my system. Honestly I hadn't considered that it can break something or something. I haven't tried it in a case where half of the stuff is not broken.