bbusschots / hsxkpasswd

A Perl module and terminal command for generating secure memorable passwords inspired by the fabulous XKCD web comic and Steve Gibson's Password Hay Stacks. This is the library that powers www.xkpasswd.net
http://www.bartb.ie/xkpasswd
BSD 2-Clause "Simplified" License
277 stars 48 forks source link

Fix type check for args passed to add_words() #44

Closed paultcochrane closed 2 hours ago

paultcochrane commented 5 days ago

@tobyink and @perlpunk worked out in https://rt.cpan.org/Public/Bug/Display.html?id=144672 that the closing square brace in the types check to the add_words sub was not in the correct place. As mentioned by @tobyink in the RT ticket:

Versions of Type::Params prior to 2.000000 would not have spotted this mistake

@perlpunk provided the patch which I'm submitting in this commit.

This change makes the test suite pass again and would hence close both issue #42 and issue #38.

This PR is submitted in the hope that it is useful. If you need anything changed, please don't hesitate to let me know and I'll be more than happy to update and resubmit as necessary.