bcahn7 / STAT547M-hw-An-Byeongchan

0 stars 0 forks source link

hw10 ready for grading #5

Open bcahn7 opened 6 years ago

bcahn7 commented 6 years ago

hw10 ready for grading

Alexander-Morin commented 6 years ago

Alexander's review:

Byeongchan explores an API which tracks stock market trends by focusing on Apple and Amazon, while also looking at crypto currencies.

Small suggestion: you can include message = FALSE and warning = FALSE in your r code chunk to suppress the package loading messages. So

```{r, message = FALSE, warning = FALSE}

The httr and jsonlite packages are successfully used to extract this information, and a function is made to generalize the task. Further data manipulation using the purrr and glue packages is performed to format the result. There are some parts where the code is hard to read but this is an unfortunate consequence of the markdown formatting and not a fault of the coder.

This extracted information is used to plot and explore cumulative trends, as well as provide summary statistics on the returns.

Overall great job, demonstrated understanding of the topic and also provided information on finance.

yuanjisun commented 6 years ago

Hello @bcahn7,

You did a great job on this assignment! Here is my comment.

Pro

  1. You get data from API successfully and developed your exploration step by step, from easy one to BTC, ETH, XRP, and AAPL.
  2. You wrote a function, which works well and is easy to be used in the future.
  3. I am glad that you continued your work from HW7, and make the data analysis deeper.
  4. Your comments of variables used in the code are really helpful. Well done!
  5. Good to see that you formatted the table output.
  6. I learned a lot from your assignment, such as fromJSON(), lapply(), etc.
  7. Figures are really good and look professional.
  8. You paid special attention to the data type. I saw a lot of conversion such as as.date(). Wonderful!

Reflection

  1. Your reflection is detailed. I can see that you ran into problems and how you solved them. By reading your experience, I learned a lot and will pay attention to those issues.

Suggestions

  1. In figures, it would be better to label the date in Jan 2017 or 01-2017, which may be easier to read.
  2. It would be better to remove the warning and other outputs such as when loading libraries.

Overall, I like your work and it is great!

Yuanji

derekcho commented 6 years ago

Hi @bcahn7, here are some comments about your hw10:

Task(s) selected: Make API queries “by hand” using httr Data stored as file ready for downstream analysis: No Basic Exploration: Yes Reflection: Yes

Your grade will be emailed to you at a later date.