search

bcgit / pc-dart

Pointy Castle - Dart Derived Bouncy Castle APIs
MIT License
233 stars 122 forks source link

Implement ability to use OAEP encoding parameters #175

Closed edwardmp closed 1 year ago

edwardmp commented 1 year ago

Prior to this commit, there was no mechanism to provide encoding parameters. This commit adds that ability.

Any feedback is welcome.

Fixes #174

edwardmp commented 1 year ago

@mwcw could you maybe take a look? Unless you have feedback I'd like to merge this upstream as soon as possible

mwcw commented 1 year ago

I am looking at it today.

MW

mwcw commented 1 year ago

Hi,

Sorry I am going to be unable to get to finish it today, I have had a look, I need to get hold of some more test vectors.

MW

edwardmp commented 1 year ago

@mwcw no problem, keep me posted

edwardmp commented 1 year ago

@mwcw what do you mean by more test vectors? Isn't the encryption/decryption test I added enough?

mwcw commented 1 year ago

Hi,

Thanks this has been merged.

MW

edwardmp commented 1 year ago

@mwcw great, but it doesn't actually seem to have merged?

mwcw commented 1 year ago

Sorry, I am in UTC+11 and I didn't finish it off in time.

edwardmp commented 1 year ago

Hi @mwcw , any way I can help prepare for the next release so I no longer need to use my own fork to have this functionality ;) ?