Required fields are not marked in red on the Review page

[elliottSlee]

• [ ] Conditional required field: If Does your Project span multiple provinces/territories? == Yes AND Provinces is not answered Then Provinces should show up red in dashboard but it doesn't currently appear.

#

• [ ] Missing fields of other funding sources page are not highlighted red but should be.

#

• [ ] Type of organization marked as missing even though something is entered.

  This doesn't occur if all fields are filled:

#

• [ ] Is this Applicant organization an Indigenous identity? question doesn't appear on the review page. The answer does.

#

• [ ] Organization profile section missing open-ended responses that appear dependent on previous question.

#

• [ ] Organization location shows false flag that something's missing when Is the mailing address the same as above? == no despite all fields filled. If mailing address same == yes, it correctly does not have a flag.

#

• [ ] When all required fields are completed, the review page correctly has no fields with red background, but it has the error at the top saying, "There are empty fields in your application. Applications with unanswered fields may not be assessed."

[elliottSlee]

@marcellmueller if we refactored this review page, as was suggested the other day, would some of these errors be fixed? If so, which ones? I'd like to clarify this card before sprint planning.

[marcellmueller]

Maybe ask @matthieu-foucault. I don’t see the value in rebuilding the entire review page instead of some minor bug fixes given the time constraints.

[matthieu-foucault]

The value is in ensuring code quality, removing code duplication and avoiding future bugs. If we're looking at short term value, then those bugs can definitely be fixed without refactoring, but similar bugs will come up whenever changes are made to the form schema.

[eazeredo]

Hey team! Please add your planning poker estimate with Zenhub @AntBush @marcellmueller @matthieu-foucault @wenzowski

[MarsRomer-zz]

Looking good, but just noticing that

1. the total funding for CIB should not be showing as red - it's optional (and autocalculated)
2. The total funding requested from partner is showing an old total despite deleting all the fiscal boxes: If I type something in another box then it clears it from the review page

[MarsRomer-zz]

in addition to above, I believe this should be a mandatory quesiton:

[MarsRomer-zz]

in addition to above, I believe this should be a mandatory quesiton:

[matthieu-foucault]

I created #704 and #705 for those two new issues, as they are different bugs than what is listed in this issue's description.

[MarsRomer-zz]

I am a little concerned about this. We made the decision to take the extra time to do the rjsf refactor because it would fix all the bugs on the review page and would remove the need create new bug tickets for the review page and fix them individually thereby saving us effort in the future. After all the effort in the rjsf refactor I am concerned that there are still bugs on the review page, and I wonder if we were better off fixing the bugs piecemeal.

[matthieu-foucault]

These bugs are not on the review page, but either the JSON Schema itself, or with the way calculated components work. You don't see them until the review page because it's the only place we're doing validation. The fixes will not involve updating the review page, which appears to be doing its job of displaying the form data and JSON schema as specified.