The photo displays as base64 in for OCA bundle is specified.

bcgov / bc-wallet-mobile

BC Wallet to hold Verifiable Credentials

Apache License 2.0

62 stars 50 forks source link

The photo displays as base64 in for OCA bundle is specified. #1150

Closed jleach closed 1 year ago

jleach commented 1 year ago

When using the dev showcase site the Picture attribute shows up as base64 encoded data in the credential offer when using the Bifold version of the iOS application. I think this data is meant for a machine and should be abstracted away in no OCA is set, perhaps just show a placeholder image or text saying "no image available".

Screenshot 2023-06-05 at 10.40.48 AM.png

swcurran commented 1 year ago

The data is the image. I would think even without the OCA, the wallet should be able to detect that the data value is a data URL and decode it appropriately, displaying the image.

wadeking98 commented 1 year ago

Resolved by: https://github.com/hyperledger/aries-mobile-agent-react-native/pull/814

nodlesh commented 1 year ago

This is now working in automated regression test T002.1-CredentialOffer & T008-CredentialOffer. Image is showing on both platforms in build 978.