Closed cvarjao closed 1 year ago
Some screen still have cut off buttons. See attached the home screen, contacts, and PIN screen:
@knguyenBC @cvarjao How is Zoom enabled on Android (which is what this bug references)? I can turn on Magnification but that allows me to pan the screen to get what I need in view. Are the examples above just font size set to extra large? Thanks.
There's display size and font size that people can configure. Both are in settings. I had maxed out both settings and they do not allow panning.
Tested with build 683 on a Samsung Galaxy S10 Android 11. I maxed out the display size and the font size as mentioned by Kim. These issues remain. We should discuss if this is acceptable.
I was not able to test on a Galaxy S10 like Sheldon used, but most of these issues have been worked on. However, the notification count badge text has not been adjusted as it is a limitation of react-navigation, see here: https://github.com/react-navigation/react-navigation/issues/10219
@bryce-mcmath Missing info icon. I assume it gets pushed to the side with text enlargement.
@wadeking98 Did you fix this one already?
I tested on a Pixel 6 emulator with Font Size and Display Sizes both set to max. All the screens look fine. Screen shots attached. Could some phones just have poor quality options for this Zoom feature? I don't think it makes sence to set your font size to 92 and expect things to look good.
Some screens could do with a little polishing. The info icon on the chat screen is a little cut off and the "this is taking longer than it should" message when waiting for a credential offer to come through does not scroll as much as it should. Others are off a little also but I think they're quire reasonable.
The info button in the contacts details page is still a problem with longer names (it gets completely obscured) but overall, the other issues, we can say is good enough. The main goal is to ensure functionality is still there, so as long as the button or text is still somewhat visible and tap-able. It's less about ensuring its still visibly appealing.
@knguyenBC The Pixel 6 i tested on has a 6.4" screen size where as the OnePlus 6 I think you used for testing has a slightly larger size of 6.82". I'll fix the contact details info button.
This issue mirrors hyperledger/aries-mobile-agent-react-native#773 which was created for the community to see.