bcgov / bc-wallet-mobile

BC Wallet to hold Verifiable Credentials
Apache License 2.0
62 stars 50 forks source link

App not formatting properly with zoomed view selected for Android (Accessibility) #619

Closed cvarjao closed 1 year ago

cvarjao commented 2 years ago

This issue mirrors hyperledger/aries-mobile-agent-react-native#773 which was created for the community to see.

knguyenBC commented 1 year ago

Some screen still have cut off buttons. See attached the home screen, contacts, and PIN screen: 20221205_170308.jpg20221205_170323.jpg20221205_170421.jpg

nodlesh commented 1 year ago

@knguyenBC @cvarjao How is Zoom enabled on Android (which is what this bug references)? I can turn on Magnification but that allows me to pan the screen to get what I need in view. Are the examples above just font size set to extra large? Thanks.

knguyenBC commented 1 year ago

There's display size and font size that people can configure. Both are in settings. I had maxed out both settings and they do not allow panning.

nodlesh commented 1 year ago

Tested with build 683 on a Samsung Galaxy S10 Android 11. I maxed out the display size and the font size as mentioned by Kim. These issues remain. We should discuss if this is acceptable. Screenshot_2023-02-01_at_11_14_04_AM.jpgScreenshot_2023-02-01_at_11_16_14_AM.jpgScreenshot_2023-02-01_at_11_20_27_AM.jpgScreenshot_2023-02-01_at_11_21_41_AM.jpgScreenshot_2023-02-01_at_11_22_01_AM.jpg

bryce-mcmath commented 1 year ago

I was not able to test on a Galaxy S10 like Sheldon used, but most of these issues have been worked on. However, the notification count badge text has not been adjusted as it is a limitation of react-navigation, see here: https://github.com/react-navigation/react-navigation/issues/10219

knguyenBC commented 1 year ago

@bryce-mcmath Screenshot_20230406-132224 (2).jpg Missing info icon. I assume it gets pushed to the side with text enlargement.

jleach commented 1 year ago

@wadeking98 Did you fix this one already?

jleach commented 1 year ago

I tested on a Pixel 6 emulator with Font Size and Display Sizes both set to max. All the screens look fine. Screen shots attached. Could some phones just have poor quality options for this Zoom feature? I don't think it makes sence to set your font size to 92 and expect things to look good.

Some screens could do with a little polishing. The info icon on the chat screen is a little cut off and the "this is taking longer than it should" message when waiting for a credential offer to come through does not scroll as much as it should. Others are off a little also but I think they're quire reasonable.

Screenshot 2023-05-16 at 5.07.07 PM.png

Screenshot 2023-05-16 at 4.36.42 PM.png

Screenshot 2023-05-16 at 5.13.13 PM.png

Screenshot 2023-05-16 at 4.36.28 PM.png

Screenshot 2023-05-16 at 4.36.14 PM.png

Screenshot 2023-05-16 at 5.18.30 PM.png

knguyenBC commented 1 year ago

The info button in the contacts details page is still a problem with longer names (it gets completely obscured) but overall, the other issues, we can say is good enough. The main goal is to ensure functionality is still there, so as long as the button or text is still somewhat visible and tap-able. It's less about ensuring its still visibly appealing.

jleach commented 1 year ago

@knguyenBC The Pixel 6 i tested on has a 6.4" screen size where as the OnePlus 6 I think you used for testing has a slightly larger size of 6.82". I'll fix the contact details info button.