bcgov / bcbb

A collection of modules for the Drupal base build used to streamline the build and deployment of applications at Ministry of Finance.
GNU General Public License v2.0
2 stars 0 forks source link

BC theme by default #16

Closed NicoledeGreef closed 1 year ago

NicoledeGreef commented 1 year ago

OP timer


This feature support the following requirements

base-build

Additional context

Since Drupal is moving away from profiles, this cannot be enabled by default.

We need to make sure the theme looks correct no matter what settings are applied.

Proposed solution

Try the various theme settings for the BB. Make sure they all look decent. Once that is done, for future projects, enable the theme and configure as needed.

Estimated level of effort

Definition of done (DoD)

Testing

Automated functional tests

CraigClark commented 1 year ago

@lkmorlan is this the sort of thing we should have automated tests for? Check that black text isn't on a grey background, that sort of thing?

lkmorlan commented 1 year ago

We can easily have a test that checks for what theme is enabled. But in principle, it should be possible to switch out the theme independent of everything else. Checking contrast is a different story. That requires different testing tools.