bcgov / bcgroundwater

An R package to facilitate analysis and visualization of groundwater data from the British Columbia groundwater observation well network
Apache License 2.0
20 stars 4 forks source link

Adds additional vignette #26

Closed stephhazlitt closed 6 years ago

stephhazlitt commented 6 years ago

Additional vignette provides an example trend analysis workflow.

stephhazlitt commented 6 years ago

Ready for a code & usefulness review @ateucher, at your convenience.

ateucher commented 6 years ago

I guess the only other thing is if we want any discussion/comparison of the two methods. They both give similar (overall) results; Seasonal M-K has more power than using average annual values... etc

stephhazlitt commented 6 years ago

Thanks! I will incorporate the useful nitpicks 👍 I think my thought was more around here is some 'how to' code, some text around test choice would be useful. Happy to accept a PR 😉.