19822 Fixed NR validation on submit

bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application

Apache License 2.0

7 stars 48 forks source link

19822 Fixed NR validation on submit #656

Closed severinbeauvais closed 9 months ago

severinbeauvais commented 9 months ago

Issue #: bcgov/entity#19822

Description of changes:

app version = 5.9.1
use applicant phone/email (if available) to fetch NR on app start
use applicant phone/email (if available) to validate NR on file and pay
save applicant phone/email to draft amalgamation, continuation in and restoration
added store getter
misc cleanup
fixed unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 9 months ago

/gcbrun

bcregistry-sre commented 9 months ago

Temporary Url for review: https://business-create-dev--pr-656-j1e446e4.web.app

SB says, try this restoration filing (as staff) (with NR 6038389/1234/sss@ggg.ccc): https://business-create-dev--pr-656-j1e446e4.web.app/restoration-business-name?id=BC0871154&accountid=3040

SB says, try this incorporation application (as BCREG0020/Severin Dev Account): https://business-create-dev--pr-656-j1e446e4.web.app/incorporation-define-company?id=TBv5Dc0hRP&accountid=2288 (In this example, there is no applicant email or phone but the NR is affiliated to the current account.) (This should also work with IDIR login because staff don't need to be affiliated.)

JazzarKarim commented 9 months ago

Temporary Url for review: https://business-create-dev--pr-656-j1e446e4.web.app

SB says, try this restoration filing (as staff) (with NR 6038389/1234/sss@ggg.ccc): https://business-create-dev--pr-656-j1e446e4.web.app/restoration-business-name?id=BC0871154&accountid=3040

SB says, try this incorporation application (as BCREG0020/Severin Dev Account): https://business-create-dev--pr-656-j1e446e4.web.app/incorporation-define-company?id=TBv5Dc0hRP&accountid=2288 (In this example, there is no applicant email or phone but the NR is affiliated to the current account.) (This should also work with IDIR login because staff don't need to be affiliated.)

For some reason, I can't open both links (This filing type is not available at the moment. Please check again later.). Pretty sure it's unrelated to the work here though.

severinbeauvais commented 9 months ago

For some reason, I can't open both links (This filing type is not available at the moment. Please check again later.). Pretty sure it's unrelated to the work here though.

Weird. I just accessed both from my cell! Login with IDIR for the first one and BCREG0020 for the second one.

severinbeauvais commented 9 months ago

app version = 5.9.1

Oops, this should have been 5.9.0. Not that it matters much, and I do think this is a large enough change (since it affects at least 3 filings) to merit a minor version bump.