search

bcgov / citz-imb-sso-react

An npm package for integrating with https://bcgov.github.io/sso-requests in a nodejs react frontend.
https://coco-frontend-argo-baf95e-prod.apps.silver.devops.gov.bc.ca/
Apache License 2.0
11 stars 0 forks source link

isLoggingIn never true #59

Closed GrahamS-Quartech closed 6 months ago

GrahamS-Quartech commented 7 months ago

I'm testing out this new property and it never seems to be in the true state. I would expect it to be true until the isAuthenticated goes from false to true or if some failure occurs. I think this behavior may be improved by simply setting the initialState to have isLoggingIn as true, but not entirely sure.

BradyMitch commented 7 months ago

Thanks I'll look into this. I know it is true before the user is redirected to the login page, but not after they get redirected back because the state gets reset. Setting by initialState might be the answer.

BradyMitch commented 7 months ago

On second thought this may not be the best option because that would act the same way as isAuthenticated. Maybe we just set it on page load after the user is redirected back after login and the refresh_expires_in query param is set in the file src\components\Wrapper.tsx

BradyMitch commented 6 months ago

This will be partially fixed in https://github.com/bcgov/citz-imb-sso-react/pull/78 After the user returns from the sso login page, for a split second it will be false but then it fill become true

Once merged and released this will part of version 1.0.0-alpha7

BradyMitch commented 6 months ago

Closing as this is addressed in version 1.0.0-alpha7