bcgov / ckan-ui

CKAN UI - VueJS
GNU Affero General Public License v3.0
14 stars 3 forks source link

GeoSpatial attributes should not be Visible when Viewing other Resource Types (DDS-1071) #312

Open annikaLiving opened 3 years ago

annikaLiving commented 3 years ago

The following fields are visible in View mode for Tabular, Webservices/API and Application Resources, yet only belong to Resources for BCGW Geospatial datasets.

These fields should not be visible if not populated as many Geospatial datasets also do not include these and never will as they are only for a subset of datasets. These will lead to consumer confusion as these will never be populated for any of these resource types.

Logic:

  1. Exists if where bcdc_type = 'geographic'

2 Does not exist if where where bcdc_type in ('tabular/document', 'webservice','application')

SteveChapmanBCDX commented 3 years ago

We should probably do an audit to make sure that each resource type is displaying relevant fields (and no other fields).

annikaLiving commented 3 years ago

@SteveChapmanBCDX good point as I see Application, Webservices and Tabular are all showing the same fields and this is not the case in Cat Classic. Where as Application and WebServices should only have a few fields. Confirmed in Cat Classic that they have the following but others could be useful:

Did the UI mock ups I did ~6 months ago get written up as these outlined what fields should be for each resource type?

SteveChapmanBCDX commented 3 years ago

@annikaLiving - We'll have to confirm with @yuisotozaki. I'm pretty sure that he did separate mockups for each of the resource types and then modified the views based on the review meetings that we did last fall (Yui, you, me, Brandon, DAs).

yuisotozaki commented 3 years ago

Yes the separate fields per resource type was discussed amongst the team before. No, we didn't create a design for each resource type.

annikaLiving commented 3 years ago

@TerryLanktree this is one of the tix we are going to discuss this afternoon.

annikaLiving commented 3 years ago

These fields are wrong on bcdc_types where not geographic and bcgw and thus should be removed.

ghost commented 2 years ago

https://dpdd.atlassian.net/browse/DDS-1071