bcgov / entity

ServiceBC Registry Team working on Legal Entities
Apache License 2.0
23 stars 59 forks source link

FED Filing for Continuation In Does Not Fail When Date Selected is After NR Expiration Date #22180

Closed riyazuddinsyed closed 2 weeks ago

riyazuddinsyed commented 4 months ago

Describe the bug in the current situation The FED filing for Continuation In does not fail when the selected date is after the Name Reservation (NR) expiration date. This allows filings to proceed with expired NR dates, which should not be permitted.

Impact of this bug Expired NR will be in the consumed state.

Steps to reproduce the behavior:

  1. Go to 'https://dev.bcregistry.gov.bc.ca/'
  2. Login with BCREGA001/98900001
  3. Search for NR 9711465
  4. Try to file the Cont In with a Future Effective Date
  5. Observe that the filing goes to the payment with no errors.
severinbeauvais commented 4 months ago

This was never a requirement so it was never implemented (for IA/registration/amalgamation/continuation).

In fact, there is code in Legal API to extend the NR expiry date to the FE date so that the filing will go through. Maybe this was the requirement?

Anyway, Riyaz, your test filing should go through successfully (no bug).

severinbeauvais commented 4 months ago

Blocked while awaiting requirements.

vikas-gov commented 4 months ago

Confirm the expected behavior based on requirements - feedback from policy adv. @OlgaPotiagalova

OlgaPotiagalova commented 1 month ago

More discussion is needed if this is an issue or not.

severinbeauvais commented 1 month ago

I believe this is not an issue -- Create UI does not give you an error if you select a FE date past the NR expiry date, but when the application is filed then we automatically extend the NR expiry date past the FE date so that the filing will succeed. So, there is really no error to display. I think we can close this ticket.

severinbeauvais commented 2 weeks ago

Please close if you agree with the analysis above.