bcgov / foi-flow

Freedom of Information modernization
Apache License 2.0
5 stars 3 forks source link

Polygon Redaction Tool #3654

Open liseandtea opened 1 year ago

liseandtea commented 1 year ago

Assumptions & Scope What are the assumptions for this story?

Hand written notes are common for some ministry clients. Analyst require a polygon tool to redact these, as they are not 90 degrees on the page.

When analyst is on a page where the information needed to be redacted cannot be captured by using the rectangular-shaped redaction tool, they will use the polygon redaction tool.

Amount of effort will depend on PDFTron enhancement or custom development.

There is a polygon tool in the shapes menu, but not in the redaction menu. We want to add the polygon tool to the redaction menu and have it behave similar to the polygon tool in the shapes menu.

What is IN scope?

Polygon tool for redaction. Solution TBD.

What is NOT in scope? Applying the FOIPPA Sections is covered in #3313. Will be same pattern, using FOIPPA modal to apply a redaction.

Acceptance Criteria

Scenario 1: Polygon Redaction Tool Option

Scenario 2: Selecting the Polygon Redaction Tool

Scenario 3: Begin to draw a polygon

Scenario 4: Draw a new red line.

Scenario 5: Opening the FOIPPA modal from the polygon tool

Scenario 6: Completing a polygon

This is blocked by #3524

Validation Rules? (If yes, list here)

Design @xxx - please link the Design here

Definition of Ready

  1. [ ] Is there a well-articulated User Story?
  2. [ ] Is there Acceptance Criteria that cover all scenarios (happy/sad paths)?
  3. [ ] If there is a user interface, is there a design?
  4. [ ] Does the user story need user research/validation?
  5. [ ] Does this User Story needs stakeholder approval?
  6. [ ] Design / Solution accepted by Product Owner
  7. [ ] Is this user story small enough to be completed in a Sprint? Should it be split?
  8. [ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
  9. [ ] Has the story been estimated?

Definition of Done

  1. [ ] Passes developer unit tests
  2. [ ] Passes peer code review
  3. [ ] If there's a user interface, that passes UX assurance
  4. [ ] Passes QA of Acceptance Criteria with verification in Dev and Test
  5. [ ] Confirm Test cases built and succeeding
  6. [ ] No regression test failures
  7. [ ] Test coverage acceptable by Product Owner
  8. [ ] Ticket ready to be merged to master or story branch
  9. [ ] Developer to list Config changes/ Update documents and designs
  10. [ ] Can be demoed in Sprint Review
  11. [ ] Tagged as part of a Release
  12. [ ] Feature flagged if required
  13. [ ] Change Management activities done?
liseandtea commented 1 year ago

@lmullane @m-prodan @KyEggleston let me know if I missed anything!

KyEggleston commented 1 year ago

@liseandtea @m-prodan @lmullane - Just to confirm, we'd want the polygon redaction tool functionality to mimic the polygon 'shapes' tool in the redaction app? This would probably be the easiest, if feasible. Can add this to the assumptions/scope of this ticket.

image

liseandtea commented 1 year ago

@KyEggleston @lmullane @m-prodan Yes, we want to mimic the same capability as the polygon drawing tool in "Shapes"

lmullane commented 1 year ago

@KyEggleston, to confirm AC matches how the polygon tool works in shapes.

@liseandtea to update AC to match the what happens when you redact with the FOIPPA modal, #3313

@m-prodan

liseandtea commented 1 year ago

@lmullane @KyEggleston @m-prodan updated the AC for this ticket. Let me know if it makes sense or if anything is missing.

m-prodan commented 1 year ago

Hi Lise - nice work on the updates. I made a slight tweak to scenario 5, but this looks pretty good to me!

lmullane commented 1 year ago

Thanks for all of your work on this, @liseandtea. I have made some edits to the AC and assumptions.

lmullane commented 1 year ago

Need to complete the research task #3524 before an estimate can be made. As likely we will need to do custom development.

lmullane commented 1 year ago

Need to complete the research task #3524 before an estimate can be made. As likely we will need to do custom development.

abin-aot commented 1 year ago

Refinement comments

KyEggleston commented 1 year ago

Decision is to wait to see if this feature will be developed by vendor, rather than custom development at the moment.