bcgov / foi-flow

Freedom of Information modernization
Apache License 2.0
5 stars 3 forks source link

Add all Request States as filters on Advanced Search #4921

Open lmullane opened 9 months ago

lmullane commented 9 months ago

Assumptions & Scope What are the assumptions for this story?

Requested by CFD who have trouble easily finding request on their request queue but applicable to all users.

What is IN scope? Add all request states as clickable search boxes on Advanced Search. Currently on these states: Unopened, Call for Records, Records Review, Ministry Sign Off, Closed

Add these states: Intake in Progress, Redirect, Section 5, Application Fees, Open, Fee Estimate, On Hold, Deduplication, Harms Assessment, Peer Review, Consult, Response

What is NOT in scope? Clicking a checkbox is already completed

Acceptance Criteria

Scenario 1: Request State Dropdown

Scenario 2: Select Request State to search

Scenario 3: Select state to search

Scenario 4: Apply Request State search

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)

Validation Rules? (If yes, list here)

Design @xxx - please link the Design here

Definition of Ready

  1. [ ] Is there a well articulated User Story?
  2. [ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
  3. [ ] If there is a user interface, is there a design?
  4. [ ] Does the user story need user research/validation?
  5. [ ] Does this User Story needs stakeholder approval?
  6. [ ] Design / Solution accepted by Product Owner
  7. [ ] Is this user story small enough to be completed in a Sprint? Should it be split?
  8. [ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
  9. [ ] Has the story been estimated?

Definition of Done

  1. [ ] Passes developer unit tests
  2. [ ] Passes peer code review
  3. [ ] If there's a user interface, passes UX assurance
  4. [ ] Passes QA of Acceptance Criteria with verification in Dev and Test
  5. [ ] Confirm Test cases built and succeeding
  6. [ ] No regression test failures
  7. [ ] Test coverage acceptable by Product Owner
  8. [ ] Ticket ready to be merged to master or story branch
  9. [ ] Developer to list Config changes/ Update documents and designs
  10. [ ] Can be demoed in Sprint Review
  11. [ ] Tagged as part of a Release
  12. [ ] Feature flagged if required
  13. [ ] Change Management activities done?
lmullane commented 9 months ago

@JHarrietha-AOT we will need a design to organize all the request states.

cc @m-prodan

m-prodan commented 8 months ago

I wonder if given the volume, a dropdown would make more sense now? I am thinking the space will get too busy if we have too many states as selectable check boxes.

JHarrietha-AOT commented 8 months ago

@m-prodan I would agree dropdown with check boxes would be better, but do we think some request states (ie. the ones already in Advanced Search) Are more likely to be searched then the rest? Like should the be a most frequently used and the other with a dropdown or move them all into a dropdown? Let me know your thoughts and I can get a design together quickly for this.

m-prodan commented 8 months ago

I think they can all be in a drop down instead. For most folks, they can technically search by state in their team requests if they wanted a quick picture of their team, and I don't imagine many managers are regularly checking other team's requests by state - at least that's just my thinking on it.

JHarrietha-AOT commented 8 months ago

That makes sense to me - I'll get this design done before end of day so we can get this ticket refined

lmullane commented 8 months ago

@m-prodan, as discussed give the updated AC a read and let me know if I missed anything?

cc @JHarrietha-AOT

lmullane commented 8 months ago

@m-prodan, as discussed give the updated AC a read and let me know if I missed anything?

cc @JHarrietha-AOT

JHarrietha-AOT commented 8 months ago

@m-prodan @lmullane as discussed here is the updated design changing the request state selection to a dropdown like all of the others in Advanced Search with the checkboxes for multi selecting. Reach out if you have any questions.

Dropdown.jpg
m-prodan commented 8 months ago

Looks good @lmullane - and I like the corresponding design too @JHarrietha-AOT

KyEggleston commented 8 months ago

Dropdown should be checkbox.

sumathi-thirumani commented 8 months ago

Internal Technical Refinement (4921):

Estimate: 8

Open Questions:

  1. Information required on the option "All Active"
  2. UX suggestion for state multiselect - https://mui.com/material-ui/react-select/ Update from Bus. Refinement:
  3. There is no option as "All Active". Ignore it
  4. Follow the multi select component "Public Body".