bcgov / foi-flow

Freedom of Information modernization
Apache License 2.0
5 stars 3 forks source link

FOI Flow State - Records Ready for Review #4931

Open liseandtea opened 9 months ago

liseandtea commented 9 months ago

Assumptions & Scope

With the exception of CFD Ministry Team, only an IAO analyst can change the state to Records Ready for Review. This state will be available from CFR, Deduplication, Tagging, Ready to Scan, Consult an Peer Review states.

What is IN scope?

Reflecting the state change in IAO and Ministry queues Automatic assignment to the processing team when the state is changed What is NOT in scope?

Acceptance Criteria

*Scenario 1: IAO Analyst 'Records Ready for Review' dropdown menu

GIVEN I am an IAO analyst or CFD Ministry Coordinator WHEN the state of the request is in any of the following states: CFR, Deduplication, Tagging, Ready to Scan, Consult an Peer Review AND I have clicked on the state dropdown menu THEN the Records Ready for Review state will now be an available option.

Scenario 2: Select 'Records Ready for Review' dropdown menu

GIVEN the IAO Analyst or CFD Ministry Coordinator has clicked the state dropdown menu WHEN I click on 'Records Ready for Review' dropdown menu *THEN a modal will open with the options to 'Save Change' or 'Cancel'

Scenario 3: Cancel change to 'Records Ready for Review'

GIVEN the IAO analyst or CFD Ministry Coordinator has opened the modal for 'Records Ready for Review' WHEN I select 'Cancel' in the modal THEN the current state of the request will remain AND the dropdown menu and modal will close

Scenario 4: Save change to 'Records Ready for Review'

GIVEN the IAO analyst or CFD Ministry Coordinator has opened to modal for 'Records Ready for Review' WHEN I select 'Save Change' in the modal THEN the state of the request will become 'Records Ready for Review' AND the dropdown menu and modal will close

Scenario 5: Changing the state from 'Records Ready for Review'

GIVEN I am an IAO analyst or CFD Ministry Coordinator and the request state is 'Records Ready for Review' WHEN they select the state change drop down menu THEN the available states will be CFR, Tagging, Consult, Records Review, Peer Review, Ministry Sign Off Response, Closed AND choosing of any of these states will close the drop down menus and move the request into the chosen state

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)

Validation Rules? (If yes, list here)

Design @xxx - please link the Design here

Definition of Ready

  1. [ ] Is there a well articulated User Story?
  2. [ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
  3. [ ] If there is a user interface, is there a design?
  4. [ ] Does the user story need user research/validation?
  5. [ ] Does this User Story needs stakeholder approval?
  6. [ ] Design / Solution accepted by Product Owner
  7. [ ] Is this user story small enough to be completed in a Sprint? Should it be split?
  8. [ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
  9. [ ] Has the story been estimated?

Definition of Done

  1. [ ] Passes developer unit tests
  2. [ ] Passes peer code review
  3. [ ] If there's a user interface, passes UX assurance
  4. [ ] Passes QA of Acceptance Criteria with verification in Dev and Test
  5. [ ] Confirm Test cases built and succeeding
  6. [ ] No regression test failures
  7. [ ] Test coverage acceptable by Product Owner
  8. [ ] Ticket ready to be merged to master or story branch
  9. [ ] Developer to list Config changes/ Update documents and designs
  10. [ ] Can be demoed in Sprint Review
  11. [ ] Tagged as part of a Release
  12. [ ] Feature flagged if required
  13. [ ] Change Management activities done?
liseandtea commented 9 months ago

@m-prodan @lmullane @KyEggleston Here is the user story for the request ready for review state. Does it make sense? Am I missing any states where we should be able to move it forward or backwards to this state?

Making note of the assumptions here: With the exception of CFD Ministry Team, only an IAO analyst can change the state to Records Ready for Review. This state will be available from CFR, Deduplication, Tagging, Ready to Scan, Consult an Peer Review states.

sumathi-thirumani commented 9 months ago

Internal Technical Refinement Note: 4931 : => 8

Assumptions: -> This is invalidated. Refer below.

  1. Any IAO user or any specific
  2. != CFD (Grammer -> exception of CFD)

**Corrected Assumptions: (Refer above comment) This new state to be shown for listed actors

  1. All IAO users
  2. CFD Ministry coordinator ONLY.**

Questions:

  1. Difference between "Records Review" vs "Records Ready for Review" -> Color Details Required. From Bus. Refinement: Jacky will update

  2. Ministry UX + behavior on this state From Bus. Refinement: The system should behave like "Records Review"

  3. "Records Ready for Review" -> To which states? (Same navigation + Records Review) From Bus. Refinement: Liz will update

  4. Does this state to be shown only when records are uploaded? From Bus. Refinement: No restrictions apply.

  5. Migration scripts

  6. Enum changes

  7. BE (Assignment changes)

  8. State Transition mapping

  9. CFD Checks + Additional

KyEggleston commented 9 months ago

@liseandtea - can you add a scenario for when a request is in 'Records Ready for Review', what request states can the request be changed to (e.g., 'Records Review', 'Call for Records', etc.)

KyEggleston commented 9 months ago

For non- CFD requests, only IAO can out the request in 'Records Ready for Review'.

Actions that can be taken in the 'Records Ready for Review' state will be the same as the 'Records Review' state.

liseandtea commented 9 months ago

@KyEggleston I added Scenario 5 to add the request states from 'Records Ready for Review'. Let me know if they make sense or not.