search

bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

Feature/deseng668: Added authoring side nav and bottom nav, modified routing, added authoring context, added base page for banner #2581

Closed jareth-whitney closed 2 months ago

jareth-whitney commented 2 months ago

Issue #: https://citz-gdx.atlassian.net/browse/DESENG-668

Description of changes:

User Guide update ticket (if applicable): N/A

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 45.78313% with 45 lines in your changes missing coverage. Please review.

Project coverage is 75.74%. Comparing base (69524c5) to head (33c3cf2).

Files with missing lines Patch % Lines
...gement/admin/create/authoring/AuthoringSideNav.tsx 33.89% 38 Missing and 1 partial :warning:
...nts/engagement/admin/view/AuthoringTabElements.tsx 20.00% 4 Missing :warning:
.../components/engagement/admin/view/AuthoringTab.tsx 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2581 +/- ## ========================================== - Coverage 76.02% 75.74% -0.28% ========================================== Files 597 603 +6 Lines 21652 21811 +159 Branches 1770 1811 +41 ========================================== + Hits 16460 16521 +61 - Misses 4936 5028 +92 - Partials 256 262 +6 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2581/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [metweb](https://app.codecov.io/gh/bcgov/met-public/pull/2581/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `64.90% <45.78%> (-0.38%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/bcgov/met-public/pull/2581?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [...web/src/components/common/RichTextEditor/index.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2581?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcommon%2FRichTextEditor%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tb24vUmljaFRleHRFZGl0b3IvaW5kZXgudHN4) | `80.00% <ø> (ø)` | | | [...nt/admin/create/authoring/AuthoringNavElements.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2581?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fadmin%2Fcreate%2Fauthoring%2FAuthoringNavElements.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2FkbWluL2NyZWF0ZS9hdXRob3JpbmcvQXV0aG9yaW5nTmF2RWxlbWVudHMudHN4) | `100.00% <100.00%> (ø)` | | | [...et-web/src/components/engagement/listing/index.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2581?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Flisting%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2xpc3RpbmcvaW5kZXgudHN4) | `76.12% <100.00%> (ø)` | | | [...eb/src/components/feedback/FeedbackModal/index.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2581?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Ffeedback%2FFeedbackModal%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9mZWVkYmFjay9GZWVkYmFja01vZGFsL2luZGV4LnRzeA==) | `88.73% <100.00%> (ø)` | | | [met-web/src/components/imageUpload/index.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2581?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2FimageUpload%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9pbWFnZVVwbG9hZC9pbmRleC50c3g=) | `100.00% <ø> (ø)` | | | [...eb/src/components/layout/Header/InternalHeader.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2581?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Flayout%2FHeader%2FInternalHeader.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9sYXlvdXQvSGVhZGVyL0ludGVybmFsSGVhZGVyLnRzeA==) | `88.39% <100.00%> (+1.01%)` | :arrow_up: | | [met-web/src/styles/Theme.ts](https://app.codecov.io/gh/bcgov/met-public/pull/2581?src=pr&el=tree&filepath=met-web%2Fsrc%2Fstyles%2FTheme.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvc3R5bGVzL1RoZW1lLnRz) | `100.00% <ø> (ø)` | | | [.../components/engagement/admin/view/AuthoringTab.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2581?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fadmin%2Fview%2FAuthoringTab.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2FkbWluL3ZpZXcvQXV0aG9yaW5nVGFiLnRzeA==) | `27.27% <50.00%> (ø)` | | | [...nts/engagement/admin/view/AuthoringTabElements.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2581?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fadmin%2Fview%2FAuthoringTabElements.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2FkbWluL3ZpZXcvQXV0aG9yaW5nVGFiRWxlbWVudHMudHN4) | `20.00% <20.00%> (ø)` | | | [...gement/admin/create/authoring/AuthoringSideNav.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2581?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fadmin%2Fcreate%2Fauthoring%2FAuthoringSideNav.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2FkbWluL2NyZWF0ZS9hdXRob3JpbmcvQXV0aG9yaW5nU2lkZU5hdi50c3g=) | `33.89% <33.89%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/bcgov/met-public/pull/2581/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov)
sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint