search

bcgov / orgbook-bc-client

Vue.js rewrite of OrgBook BC
Apache License 2.0
6 stars 8 forks source link

added simple advanced search page #134

Closed wadeking98 closed 2 years ago

wadeking98 commented 2 years ago

Added ability to search by credential type Resolves: #70
Signed-off-by: wadeking98 wkingnumber2@gmail.com

amanji commented 2 years ago

@swcurran Is this the intended implementation? I recall the discussion being something around linking to search results by type from the Data Types (About) section. I'm of the view that if we want to add a separate advanced search feature, perhaps we should iterate on the current search feature. Thoughts? What about you @wadeking98?

WadeBarnes commented 2 years ago

@amanji, Based on this comment I would say this is not the intended implementation; https://github.com/bcgov/orgbook-bc-client/issues/70#issuecomment-1020669080

@swcurran Is this the intended implementation? I recall the discussion being something around linking to search results by type from the Data Types (About) section. I'm of the view that if we want to add a separate advanced search feature, perhaps we should iterate on the current search feature. Thoughts? What about you @wadeking98?

swcurran commented 2 years ago

See my notes on the issue #70 -- we don't want to have this implemented in this way. We don't really want an "Advanced Search" at all, unless it provides features that are more like one would expect in an advanced search. This is definitely not that.

amanji commented 2 years ago

Ah, I should have read through the issue discussion. I agree with @swcurran on his comments. The link-based approach is much cleaner for now until we iterate on the existing search bar.

wadeking98 commented 2 years ago

@swcurran @amanji @WadeBarnes I've refactored the changes now and made it in line with Stephen's suggestion of having links on the page

wadeking98 commented 2 years ago

@swcurran here is what the page looks like: image

swcurran commented 2 years ago

How about one more tweak. Title that "Credential Search by Type" vs. "Credentials"? I think that makes it a little clearer...