search

bcgov / orgbook-bc-client

Vue.js rewrite of OrgBook BC
Apache License 2.0
6 stars 8 forks source link

Change text "expired" on Relationships section of entity page #151

Closed swcurran closed 2 years ago

swcurran commented 2 years ago

I noticed that the "expired" appears in the "Relationships" tab. See: https://orgbook.gov.bc.ca/entity/BC0338518

In that case, it is the organization that has been dissolved - not the credential. As such, the text should say "Historical", not expired, and the date should be the effective date of the dissolution -- e.g. for https://orgbook.gov.bc.ca/entity/FM0562397 it should be Oct 01, 2019.

See if this is an obvious change. If not, we can discuss the related data in a meeting with @ianco and the BC Registries folks.

wadeking98 commented 2 years ago

The text is straightforward, but the date doesn't seem to be an obvious change. Right now there's no way to grab the dissolution date from a relationship credential, because the dissolution date exists on a different credential. We will have to meet to discuss a work around.

swcurran commented 2 years ago

If the "expired" refers to the credential, then it should be prefixed with "Credential" to make it clear.

Would that solve your problem?

wadeking98 commented 2 years ago

Yes that would work

wadeking98 commented 2 years ago

closed by PR: https://github.com/bcgov/orgbook-bc-client/pull/159