bcgov / orgbook-bc-client

Vue.js rewrite of OrgBook BC
Apache License 2.0
6 stars 8 forks source link

Credential verified link is incorrect for relationships / Related organizations linking to the wrong (expired) parent record. #99

Closed WadeBarnes closed 2 years ago

WadeBarnes commented 2 years ago

Example record: https://orgbook.gov.bc.ca/entity/BC0928747

Steps to reproduce:

Observed behavior:

Expected behavior:

WadeBarnes commented 2 years ago

Further investigation indicates this is an issue with the related organization records themselves. The issue occurs regardless of how you get to the related records in this example. They are linking to the expired record of their parent organization rather than the active one. This can be seen in the screen shot above Effective: Dec 31, 1987 for https://orgbook.gov.bc.ca/entity/FM0414526.

In this example the active record for the parent organization is linking to the active DBA records, but all of the active DBA records are linking back to the expired record of the parent organization.

If you navigate from the parent organization to a related organization and then click on the relationship link to the parent organization this becomes more clear.

You see this: image

Rather than returning to the record you started from: image

WadeBarnes commented 2 years ago

This is not an issue with the previous UI as is displays both parent relationships, the active one and the expired (archived) one. This can currently be seen here; https://frontend-prod.apps.silver.devops.gov.bc.ca/en/organization/registration.registries.ca/FM0414526

swcurran commented 2 years ago

I see the expired issue and agree that it needs to be addressed. Not sure I get the initial sequence as being wrong -- it's going to where I expect (except for landing on the expired record).

WadeBarnes commented 2 years ago

The initial sequence is talking about the incorrect link for Credential verified. You go to the correct organization record, however that record's Credential verified link is wrong, it will take you to the main search page, rather than the credential details for the organization you are viewing.

swcurran commented 2 years ago

Priority for cleanup

wadeking98 commented 2 years ago

I think we should split this into two issues. The issue with the relationship linking back to an expired credential seems to be a data issue, whereas the "credential verified" link can be solved on the frontend.