bcgov / performance

Performance
Apache License 2.0
0 stars 2 forks source link

Incorrect recipients name for notifications sent for shared goal #1346

Open steffipravasi opened 3 months ago

steffipravasi commented 3 months ago

Issue connected to ticket #1103 Test data: Goal owner - Travis clark Goal name: Testing Private Goal June 28,24 Goal shared with:

1) Travis added a comment to the goal. All the 4 shared users received notifications, but the recipient name in the email is incorrect.

Screenshot 2024-07-30 at 4.45.59 PM.png

2) Sophia added a comment to the goal, the recipient name is still displayed as the goal owner's name

Screenshot 2024-07-30 at 4.52.43 PM.png

3) In the notifications page, the in-app notifications recipients name is incorrect

Screenshot 2024-07-30 at 4.47.41 PM.png
jizhaogit commented 3 months ago

Hi @steffipravasi, the fix should be included in #1103. would you please help verify? thanks!

steffipravasi commented 3 months ago

@jizhaogit The same issues are still seen. Can you confirm if the fix is in the test region?

Screenshot 2024-08-01 at 10.56.41 AM.png
jizhaogit commented 3 months ago

Hi @steffipravasi , please let me know the goal's id you used for this testing. thanks!

steffipravasi commented 3 months ago

@jizhaogit Goal id: 1010 https://performance-332842-test.apps.silver.devops.gov.bc.ca/goal/1010

jizhaogit commented 3 months ago

should be addressed. please help verify. thanks

steffipravasi commented 3 months ago

Issue has been addressed and name displayed correctly

jessicahjwu commented 2 months ago

In Training, Jessica shared a goal with Stephanie Revel, Margaret Burrows, and Zehra Le Roy, and added a comment to the shared goal. However, according to the notification log, the recipient was Jessica Wu:

image.png

Although, Zehra has this notification on her dashboard:

image.png

Jessica did not receive the notification on dashboard:

image.png