bcgov / von-bc-registries-agent

Apache License 2.0
3 stars 17 forks source link

Sole proprietorships reported as missing in OrgBook #341

Closed WadeBarnes closed 9 months ago

WadeBarnes commented 9 months ago

The sole proprietorships FM0412628 and FM0497782 are being reported as missing from the OrgBook by the BC Reg Audit Script's COLIN audit. The latest LEAR audit shows no records are missing.

This has occurred since a number of LEAR records were updated to address https://github.com/bcgov/von-bc-registries-agent/issues/339.

The fact that these records are being reported by the COLIN audit seems to indicate the records are still in COLIN, but for some reason the audit script can't find them or is not including them in the scope of the COLIN audit.

WadeBarnes commented 9 months ago

cc @droberts27, @esune

WadeBarnes commented 9 months ago

@droberts27, Any insight into the state of these records on the COLIN and LEAR side of things?

swcurran commented 9 months ago

@droberts27 — is there a place that we can put these issues in the BC Registries backlog? These types of things are not OrgBook BC issues — they just surface because OrgBook BC is pulling inconsistent data from COLIN and LEAR.

WadeBarnes commented 9 months ago

Update from David

This issue spans LEAR, CPRD, and Orgbook.

FM0412628 and FM0497782 were created as sole proprietorships (SP) in CPRD and included in OrgBook as SP. During October, 2022 they were migrated to LEAR as SP and frozen in CPRD. There have been no subsequent filings in LEAR. During August, 2023 they were datafixed in CPRD to be Limited Partnerships (LP). Currently they are frozen in CPRD and incorrectly showing as SP in LEAR and Orgbook.

The solution is:

David: unfreeze FM0412628 and FM0497782 in CPRD Richard: Delete FM0412628 and FM0497782 from LEAR Orgbook: Update FM0412628 and FM0497782 to be LP in Orgbook

swcurran commented 9 months ago

To be a little more precise — Orgbook: Requeue FM0412628 and FM0497782 to be clear that we don’t do anything in OrgBook other than take what is retrieved from BC Registries systems.

Thanks for the investigation and updates @WadeBarnes !

WadeBarnes commented 9 months ago

David has unfrozen the affected records. Next step is with Richard.

WadeBarnes commented 9 months ago

Richard deleted the records from LEAR.

I requeued and reprocessed the records and now they are showing up in OrgBook as LPs as expected.

https://orgbook.gov.bc.ca/search?q=FM0412628&category%3Aentity_type=&credential_type_id=&inactive=&page=1 image

https://orgbook.gov.bc.ca/search?q=FM0497782&category%3Aentity_type=&credential_type_id=&inactive=&page=1 image