bchanudet / OctoPrint-Octorant

Discord plugin for OctoPrint
MIT License
26 stars 14 forks source link

Feature Suggestion: Add option to give time-based progress updates #11

Closed Patronics closed 1 year ago

Patronics commented 6 years ago

It would be useful to have an option for time based progress updates, for example on very long prints an update every (for example) 10% would not come often, while small prints would have constant notifications. It would be great to be able to set it to (for example) every hour give a progress update if it hasn't given one during that periopd based on hitting a target percentage (or have it run entirely independently/instead of percentage-based progress updates). Based on my (limited) research of the OctoPrint plugin system, it seems you may need to get the time from another source than the payload data passed by the progress/event hooks.

bchanudet commented 6 years ago

Hello and thanks for your feedback (and for your PR too!)

Time-based progress updates can indeed be a good thing to have regular update no matter how long the full printing process is gonna take.

I also experienced a bug in the last days where I relaunched a print of an updated file, but OctoPrint didn't reset the percentage according to the new file size, and I ended up getting a 125% notification...

There is two ways I can look into this:

Maybe I could offer the three solutions, and the user would have to select one (or more) of them, depending on their notification preferences.

What do you think?

Patronics commented 6 years ago

Thanks for replying, and I agree that either of those options would be great, and it’d probably be best to have both options 😀. That’s one thing I love about you plugin, how much configuration it allows for customization 😄.

cdub3d commented 4 years ago

Hi, I just found out about this plugin today, and I had a similar question but for different reasons. I have a printer I do not control via Octoprint for various reasons, but I do have an Octoprint setup running with the pi-cam. I use it to stream using youtube live plugin when I have to drive away for work when something is printing. So I was wondering about the timed option. Not polling octoprint for any status of the printer/job at all... only sending snapshots based on time settings.