Add toolbox script path to environment path

[imazine]

Append toolbox script path to PATH variable This commit for fix #294

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[bchatard]

Hi,

where are located your JetBrains binaries? In ${process.env.HOME}/Library/Application Support/JetBrains/Toolbox/scripts?

Per default it's /usr/local/bin and this path is available to $PATH with no additional configuration

[imazine]

@bchatard I am a Jetbrain Toolbox user and my binaries located in ~/Library/Application Support/Jetbrain/Toolbox/scripts It is default shell script location of toolbox. I suggest two solution for this issue. First is add a default script path(like this PR) and the other is add subtle guide for set a default shell script location to system default (e.g. /usr/loal/bin but It need to root permission)

[bchatard]

Same for me, I'm using Toolbox since the beginning and scripts are still localized in ˋ/usr/local/binˋ. Maybe a change in fresh toolbox install. Anyway, did the script can be run in your terminal? Maybe you should add the path to your ˋ$PATHˋ in your ˋ~/.zshrcˋ.

[imazine]

@bchatard I guess your /usr/local/bin permission is not same with OS default(It is not writable without root permission). and I tried to change $PATH in my .zshrc configuration but It did not works.

[bchatard]

It was writable few months ago, so that the reason I use it.

Did you script works in your terminal? Eg: calling cd /path/to/projeect && idea .

[imazine]

@bchatard I can't find any reference about /usr/local/[sub_directories] changed to writable. If it was available then any application with user permission can change other binaries under the location. I guess your path was changed by yourself.

[GertVil]

Same issue here after using a new laptop, and idea in the terminal does work.

[bchatard]

Hi @GertVil

since the bin doesn't work in your terminal, the issue is not related to this workflow

[GertVil]

Hey @bchatard

You might have misread my original message, using idea in the terminal does in fact work

➜  /tmp mkdir test-project
➜  /tmp cd test-project
➜  test-project which idea
/Users/gert/Library/Application Support/JetBrains/Toolbox/scripts/idea
➜  test-project idea .
➜  test-project

and Intellij opens inside the test-project dir. I applied this MR locally, and it fixes the workflow. Default settings are the same as @imazine 's

[bchatard]

Oups sorry

Can you try to echo your $PATH in Alfred script filter?

[GertVil]

Yeah as per https://www.alfredapp.com/help/workflows/advanced/understanding-scripting-environment/ they differ my PATH in normal shell includes the /Users/gert/Library/Application Support/JetBrains/Toolbox/scripts and the echo in the script filter does not contain /Users/gert/Library/Application Support/JetBrains/Toolbox/scripts. Do you have objections to merging this PR? Because it would probably solve the issue for a lot of people without them having to adjust the path before the script runs. Since this is the new default location toolbox uses I'm guessing the problem will arise more and more.

[bchatard]

nice catch @GertVil

as a workaround I'll merge this