bcit-ci / CodeIgniter

Open Source PHP Framework (originally from EllisLab)
https://codeigniter.com/
MIT License
18.27k stars 7.6k forks source link

Fixes the compatibility of XML-RPC library with PHP 8 #6264

Open gxgpet opened 9 months ago

gxgpet commented 9 months ago

After long thoughts and checks on this, I came up with this fix for the XML-RPC library for the new PHP 8 versions.

While I pushed a unit test and made manual tests by myself, anyone who actively uses this library and can test it with a real-world scenario would be much appreciated.

I don't see the need for the xh property to be a multi-dimensional array. If a new request gets fired, then the previous values won't be used at all.