[PATCH] 'scons check' fails on branch 1.3.x, looking for libserf-2

[GoogleCodeExporter]

Running scons && scons check on a fresh checkout of branch 1.3.x (r1999 or 
later) fails because the linker looks for libserf-2.

Steps to reproduce:
1. Checkout a copy of branches/1.3.x
2. scons && scons check
3.

Expected result:

Test programs compile and start running

Actual result:

gcc -o test/serf_get -Wl,-rpath,/home/danilo/Scrivania/Sviluppo/serf 
test/serf_get.o -L. -L/usr/lib -L/usr/lib -lserf-2 -lssl -lcrypto -lz -lapr-1 
-laprutil-1
/usr/bin/ld: cannot find -lserf-2
collect2: error: ld returned 1 exit status
scons: *** [test/serf_get] Error 1
scons: building terminated because of errors.

The attached patches replace the hard-coded libname 'libserf-2' with the 
LIBNAME variable in SConstruct.

The two patches are for branches/1.3.x and for trunk, respectively. They only 
differ in the line numbers, in order to apply cleanly.

Original issue reported on code.google.com by danilopi...@gmail.com on 9 Jul 2013 at 5:19

Attachments:

• scons_check_libname_1.3.x.diff
• scons_check_libname.diff

[GoogleCodeExporter]

Good catch, a remnant of porting our scons config to the 1.x line.

I've committed your patch to trunk in r2028 and will backport it to the 1.3.x 
branch.

Thanks!

Lieven

Original comment by lieven.govaerts@gmail.com on 9 Jul 2013 at 6:11

• Changed state: Fixed

[GoogleCodeExporter]

Thanks to you!

Danilo Piazzalunga

Original comment by danilopi...@gmail.com on 10 Jul 2013 at 12:58