Use warning instead of stop for argument deprecation

bcm-uga / pcadapt

Performing highly efficient genome scans for local adaptation with R package pcadapt v4

https://bcm-uga.github.io/pcadapt

37 stars 10 forks source link

Use warning instead of stop for argument deprecation #3

Closed zkamvar closed 7 years ago

zkamvar commented 7 years ago

In the most recent commit, you deprecated the output.filename and clean.files parameters. By using stop() instead of warning(), old scripts will break if they specify a different output prefix or decide not to clean files. A warning would allow old scripts to still run with the new version and alert the users that the parameters would change in the future.

keurcien commented 7 years ago

Hi, you're totally right, thanks for the suggestion !