search

bcnmy / biconomy-client-sdk

Biconomy SDK is a plug & play toolkit for dApps to build transaction legos that enable a highly customised one-click experience for their users
MIT License
73 stars 76 forks source link

fix: update parsing of the bundler url from config #553

Closed veljkovranic closed 1 month ago

veljkovranic commented 1 month ago

Out SDK is harded to expect v2 URL version.

This PR aims at allowing upcoming v3 version

PR-Codex overview

This PR updates the regular expression in Utils.ts to match both /api/v2/ and /api/v3/ URLs for extracting a specific number.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size
core (esm) 55.7 KB (+0.15% 🔺)
core (cjs) 60.97 KB (+0.19% 🔺)
account (tree-shaking) 53.27 KB (-0.08% 🔽)
bundler (tree-shaking) 2.54 KB (+0.2% 🔺)
paymaster (tree-shaking) 2.23 KB (0%)
modules (tree-shaking) 41.02 KB (0%)
joepegler commented 1 month ago

Thanks for this, but can you make epv7 relevant PRs into feat/nexus branch? We don't plan on accommodating ep07 for BiconomySmartAccountV2

veljkovranic commented 1 month ago

You changed the base already, should I do anything else?