bindings: fix build for windows

bcoin-org / bcrypto

JS crypto library

Other

99 stars 41 forks source link

bindings: fix build for windows #24

Closed tuxcanfly closed 5 years ago

tuxcanfly commented 5 years ago

Faced some issues building for windows, trying to fix them.

[x] Fixed gmp.h not found - bn.cc (needs rebase on master)
[x] Fixed cipherbase.h string functions
[x] Fixed bindings.gyp byte order issue
[x] Linking fails - Fixed (see https://stackoverflow.com/a/3731577)

chjj commented 5 years ago

Ah, I wasn't planning on actually switching to the native bn module yet. It's probably far too untested and links to the system install of gmp. So I disabled that for the 4.0.0 release. I want to fuzz it and valgrind it, etc, before we'd consider switching to it.

Windows doesn't support strcasecmp? That's nuts! I had no idea.

Will merge and release once the final issue is solved.