bcoin-org / bcrypto

JS crypto library
Other
99 stars 41 forks source link

ci: add build step for windows on travis #29

Closed tuxcanfly closed 5 years ago

tuxcanfly commented 5 years ago

This PR adds a build step for windows. Builds on windows require openssl and libeay32. A binary is bundled for ease of deployment.

tuxcanfly commented 5 years ago

There seems to be some DSA tests failing, will investigate:

31553 passing (150s)
  23 pending
  12 failing
  1) OpenSSL
       should deserialize DSA parameters:
      AssertionError [ERR_ASSERTION]: "-----BEGIN DSA PARAMETERS-----\nMIIBHgKBgQCZZAxSnzOba6rf2CkRGzkfKp0CZyYhsf03PL..." strictEqual "-----BEGIN DSA PARAMETERS-----\r\nMIIBHgKBgQCZZAxSnzOba6rf2CkRGzkfKp0CZyYhsf03P..."
      Expected values to be strictly equal:

      + actual - expected

      + '-----BEGIN DSA PARAMETERS-----\nMIIBHgKBgQCZZAxSnzOba6rf2CkRGzkfKp0CZyYhsf03PLVeyX5yQpt2DsBztfaa\nOrFwbOrTbCFxu7uTWutPyb9mfyyCL2tzHWI3vff48yZjY2kNAq951o81FLCR7Wvc\nETikqnZDHEC9/XdQ/pmdbe8FVVo2cdhI/28+sDqvRV4NB9XtYknbdwIVAOVMJbXj\nCCjdDaRZH9P5kAiwtp+DAoGAULZxKjbD1RWlvgW2gJlV65PAG+c5lGgpV+HFspNw\nVEfSGTXBV9SSnkHQoS8YUEcMQUXF1JsaUXMMPuZJPEJtzwxP3gu817ozIcnEHjB9\nLsfoHAFrl3eyOFtuussptlfDgJNi5dPFJBDFvSGD5JIF2vo+r7blvd4vl49NTlNI\nWBQ=\n-----END DSA PARAMETERS-----\n'
      - '-----BEGIN DSA PARAMETERS-----\r\nMIIBHgKBgQCZZAxSnzOba6rf2CkRGzkfKp0CZyYhsf03PLVeyX5yQpt2DsBztfaa\r\nOrFwbOrTbCFxu7uTWutPyb9mfyyCL2tzHWI3vff48yZjY2kNAq951o81FLCR7Wvc\r\nETikqnZDHEC9/XdQ/pmdbe8FVVo2cdhI/28+sDqvRV4NB9XtYknbdwIVAOVMJbXj\r\nCCjdDaRZH9P5kAiwtp+DAoGAULZxKjbD1RWlvgW2gJlV65PAG+c5lGgpV+HFspNw\r\nVEfSGTXBV9SSnkHQoS8YUEcMQUXF1JsaUXMMPuZJPEJtzwxP3gu817ozIcnEHjB9\r\nLsfoHAFrl3eyOFtuussptlfDgJNi5dPFJBDFvSGD5JIF2vo+r7blvd4vl49NTlNI\r\nWBQ=\r\n-----END DSA PARAMETERS-----\r\n'

      assert.strictEqual(key.toPEM(), dsaParamsPem);
             ^
      at Context.<anonymous> (C:\Users\travis\build\tuxcanfly\bcrypto\test\openssl-test.js:30:12)
      at C:\Users\travis\build\tuxcanfly\bcrypto\node_modules\bmocha\lib\bmocha.js:1153:30
      at new Promise (<anonymous>)
tuxcanfly commented 5 years ago

For reference, here's the travis log: https://api.travis-ci.org/v3/job/574160127/log.txt

tuxcanfly commented 5 years ago

Closing in favor of #31

Travis doesn't really support windows.