bcomnes / npm-run-all2

A CLI tool to run multiple npm-scripts in parallel or sequential. (Maintenance fork)
MIT License
250 stars 12 forks source link

feat: move to read-package-json-fast #130

Closed 43081j closed 8 months ago

43081j commented 8 months ago

This moves away from read-pkg to a much, much lighter package maintained by the npm team themselves (read-package-json-fast).

Saves us ~90k of install size and the time spent fetching the 15-20 dependencies read-pkg has

socket-security[bot] commented 8 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/read-package-json-fast@3.0.2 filesystem +2 22.1 kB lukekarrys

🚮 Removed packages: npm/read-pkg@8.1.0

View full report↗︎

bcomnes commented 8 months ago

Right on, let's see if it breaks anything in CI.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (79e2c97) 96.82% compared to head (62b8703) 96.31%. Report is 16 commits behind head on master.

Files Patch % Lines
lib/run-task.js 84.81% 12 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #130 +/- ## ========================================== - Coverage 96.82% 96.31% -0.52% ========================================== Files 35 35 Lines 2080 2114 +34 ========================================== + Hits 2014 2036 +22 - Misses 66 78 +12 ``` | [Flag](https://app.codecov.io/gh/bcomnes/npm-run-all2/pull/130/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [macos-latest-18](https://app.codecov.io/gh/bcomnes/npm-run-all2/pull/130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `96.22% <85.00%> (-0.53%)` | :arrow_down: | | [ubuntu-latest-18](https://app.codecov.io/gh/bcomnes/npm-run-all2/pull/130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `95.83% <85.00%> (-0.53%)` | :arrow_down: | | [windows-latest-18](https://app.codecov.io/gh/bcomnes/npm-run-all2/pull/130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `95.85% <85.00%> (-0.53%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bcomnes commented 8 months ago

Looks good, will test locally and release tomorrow.

43081j commented 8 months ago

Thanks so much for taking a look so soon! 🙏

bcomnes commented 8 months ago

No problem. I'll take all the easy, future facing improvements this can get!

bcomnes commented 8 months ago

Give https://github.com/bcomnes/npm-run-all2/releases/tag/v6.1.2 a shot.