beached / daw_json_link

Fast, convenient JSON serialization and parsing in C++
https://beached.github.io/daw_json_link/
Boost Software License 1.0
478 stars 31 forks source link

Installer in 2.9.3 may be broken. #232

Closed toge closed 3 years ago

toge commented 3 years ago

In 2.9.3, cmake installer creates such directories. I think it is a CMakeLists.txt bug in 2.9.3.

include/
├── daw
│   ├── impl
│   ├── iterator
│   └── utf_range
├── include
│   ├── daw
│   │   └── json
│   │       └── impl
│   └── third_party
│       └── dragonbox
└── utf8

For example: In 2.9.2, cmake installer create such directories.

include/
├── daw
│   ├── impl
│   ├── iterator
│   ├── json
│   │   └── impl
│   └── utf_range
├── third_party
│   └── dragonbox
└── utf8

reproduction methods

wget -nd https://github.com/beached/daw_json_link/archive/refs/tags/v2.9.3.zip
unzip v2.9.3.zip
cd daw_json_link-2.9.3/
cmake -B build -S .
mkdir /tmp/dummy
cmake --install build  --prefix /tmp/dummy/
cd /tmp/dummy
tree -d include/
beached commented 3 years ago

Thanks, I made a change to how it works and forgot the / after the folder name. Fixed with https://github.com/beached/daw_json_link/pull/233

beached commented 3 years ago

https://github.com/beached/daw_json_link/releases/tag/v2.9.4

toge commented 3 years ago

Thank you for your quick response! I confirmed it.